Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2022-06-20 Thread Fangrui Song via Gcc-patches
On Wed, Jun 15, 2022 at 2:34 AM Fangrui Song wrote: > > This was introduced in 2014-12 to use local binding for external symbols > for -fPIE. It avoids a GOT indirection but the same optimizationis > obtained with ld's R_X86_64_[REX_]GOTPCRELX optimization (albeit with > slightly longer code). >

[PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2022-06-15 Thread Fangrui Song via Gcc-patches
This was introduced in 2014-12 to use local binding for external symbols for -fPIE. It avoids a GOT indirection but the same optimizationis obtained with ld's R_X86_64_[REX_]GOTPCRELX optimization (albeit with slightly longer code). One design goal of -fPIE was to avoid copy relocations. HAVE_LD_

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2022-06-02 Thread Fāng-ruì Sòng via Gcc-patches
On Sun, Oct 31, 2021 at 7:36 PM Fāng-ruì Sòng wrote: > > On Fri, Oct 8, 2021 at 10:57 AM Fāng-ruì Sòng wrote: > > > > On Fri, Sep 24, 2021 at 11:29 AM H.J. Lu wrote: > > > > > > On Fri, Sep 24, 2021 at 11:14 AM Fāng-ruì Sòng wrote: > > > > > > > > On Fri, Sep 24, 2021 at 10:41 AM H.J. Lu wrote

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-10-31 Thread Fāng-ruì Sòng via Gcc-patches
On Fri, Oct 8, 2021 at 10:57 AM Fāng-ruì Sòng wrote: > > On Fri, Sep 24, 2021 at 11:29 AM H.J. Lu wrote: > > > > On Fri, Sep 24, 2021 at 11:14 AM Fāng-ruì Sòng wrote: > > > > > > On Fri, Sep 24, 2021 at 10:41 AM H.J. Lu wrote: > > > > > > > > On Fri, Sep 24, 2021 at 10:29 AM Fāng-ruì Sòng > >

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-10-08 Thread Fāng-ruì Sòng via Gcc-patches
On Fri, Sep 24, 2021 at 11:29 AM H.J. Lu wrote: > > On Fri, Sep 24, 2021 at 11:14 AM Fāng-ruì Sòng wrote: > > > > On Fri, Sep 24, 2021 at 10:41 AM H.J. Lu wrote: > > > > > > On Fri, Sep 24, 2021 at 10:29 AM Fāng-ruì Sòng wrote: > > > > > > > > On Tue, Sep 21, 2021 at 7:08 PM Fāng-ruì Sòng >

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-24 Thread H.J. Lu via Gcc-patches
On Fri, Sep 24, 2021 at 11:14 AM Fāng-ruì Sòng wrote: > > On Fri, Sep 24, 2021 at 10:41 AM H.J. Lu wrote: > > > > On Fri, Sep 24, 2021 at 10:29 AM Fāng-ruì Sòng wrote: > > > > > > On Tue, Sep 21, 2021 at 7:08 PM Fāng-ruì Sòng wrote: > > > > > > > > On Tue, Sep 21, 2021 at 6:57 PM H.J. Lu wrot

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-24 Thread Fāng-ruì Sòng via Gcc-patches
On Fri, Sep 24, 2021 at 10:41 AM H.J. Lu wrote: > > On Fri, Sep 24, 2021 at 10:29 AM Fāng-ruì Sòng wrote: > > > > On Tue, Sep 21, 2021 at 7:08 PM Fāng-ruì Sòng wrote: > > > > > > On Tue, Sep 21, 2021 at 6:57 PM H.J. Lu wrote: > > > > > > > > On Tue, Sep 21, 2021 at 9:16 AM Uros Bizjak wrote:

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-24 Thread H.J. Lu via Gcc-patches
On Fri, Sep 24, 2021 at 10:29 AM Fāng-ruì Sòng wrote: > > On Tue, Sep 21, 2021 at 7:08 PM Fāng-ruì Sòng wrote: > > > > On Tue, Sep 21, 2021 at 6:57 PM H.J. Lu wrote: > > > > > > On Tue, Sep 21, 2021 at 9:16 AM Uros Bizjak wrote: > > > > > > > > On Mon, Sep 20, 2021 at 8:20 PM Fāng-ruì Sòng via

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-24 Thread Fāng-ruì Sòng via Gcc-patches
On Tue, Sep 21, 2021 at 7:08 PM Fāng-ruì Sòng wrote: > > On Tue, Sep 21, 2021 at 6:57 PM H.J. Lu wrote: > > > > On Tue, Sep 21, 2021 at 9:16 AM Uros Bizjak wrote: > > > > > > On Mon, Sep 20, 2021 at 8:20 PM Fāng-ruì Sòng via Gcc-patches > > > wrote: > > > > > > > > PING^5 https://gcc.gnu.org/p

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-21 Thread Fāng-ruì Sòng via Gcc-patches
On Tue, Sep 21, 2021 at 6:57 PM H.J. Lu wrote: > > On Tue, Sep 21, 2021 at 9:16 AM Uros Bizjak wrote: > > > > On Mon, Sep 20, 2021 at 8:20 PM Fāng-ruì Sòng via Gcc-patches > > wrote: > > > > > > PING^5 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html > > > > > > On Sat, Sep 4, 2021

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-21 Thread H.J. Lu via Gcc-patches
On Tue, Sep 21, 2021 at 9:16 AM Uros Bizjak wrote: > > On Mon, Sep 20, 2021 at 8:20 PM Fāng-ruì Sòng via Gcc-patches > wrote: > > > > PING^5 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html > > > > On Sat, Sep 4, 2021 at 12:11 PM Fāng-ruì Sòng wrote: > > > > > > PING^4 https://gcc.

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-21 Thread Uros Bizjak via Gcc-patches
On Mon, Sep 20, 2021 at 8:20 PM Fāng-ruì Sòng via Gcc-patches wrote: > > PING^5 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html > > On Sat, Sep 4, 2021 at 12:11 PM Fāng-ruì Sòng wrote: > > > > PING^4 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html > > > > One major d

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-20 Thread Fāng-ruì Sòng via Gcc-patches
PING^5 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html On Sat, Sep 4, 2021 at 12:11 PM Fāng-ruì Sòng wrote: > > PING^4 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html > > One major design goal of PIE was to avoid copy relocations. > The original patch for GCC 5 cause

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-09-04 Thread Fāng-ruì Sòng via Gcc-patches
PING^4 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html One major design goal of PIE was to avoid copy relocations. The original patch for GCC 5 caused problems for many years. On Wed, Aug 18, 2021 at 11:54 PM Fāng-ruì Sòng wrote: > PING^3 https://gcc.gnu.org/pipermail/gcc-patches

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-08-18 Thread Fāng-ruì Sòng via Gcc-patches
PING^3 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html On Fri, Jun 4, 2021 at 3:04 PM Fāng-ruì Sòng wrote: > > PING^2 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html > > On Mon, May 24, 2021 at 9:43 AM Fāng-ruì Sòng wrote: > > > > Ping https://gcc.gnu.org/pipermail/

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-06-04 Thread Fāng-ruì Sòng via Gcc-patches
PING^2 https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html On Mon, May 24, 2021 at 9:43 AM Fāng-ruì Sòng wrote: > > Ping https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html > > On Tue, May 11, 2021 at 8:29 PM Fangrui Song wrote: > > > > This was introduced in 2014-12 to use

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-05-24 Thread Fāng-ruì Sòng via Gcc-patches
Ping https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570139.html On Tue, May 11, 2021 at 8:29 PM Fangrui Song wrote: > > This was introduced in 2014-12 to use local binding for external symbols > for -fPIE. Now that we have H.J. Lu's GOTPCRELX for years which mostly > nullify the benefit of HA

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-05-11 Thread Fangrui Song via Gcc-patches
On 2021-05-12, Rainer Orth wrote: Hi Fangrui, Hi Rainer, for -fPIE. Now that we have H.J. Lu's GOTPCRELX for years which mostly nullify the benefit of HAVE_LD_PIE_COPYRELOC, HAVE_LD_PIE_COPYRELOC should retire now. Solaris/x86 ld doesn't support this, so HAVE_LD_PIE_COPYRELOC needs to stay.

Re: [PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-05-11 Thread Rainer Orth
Hi Fangrui, > This was introduced in 2014-12 to use local binding for external symbols > for -fPIE. Now that we have H.J. Lu's GOTPCRELX for years which mostly > nullify the benefit of HAVE_LD_PIE_COPYRELOC, HAVE_LD_PIE_COPYRELOC > should retire now. Solaris/x86 ld doesn't support this, so HAVE_L

[PATCH] x86-64: Remove HAVE_LD_PIE_COPYRELOC

2021-05-11 Thread Fangrui Song via Gcc-patches
This was introduced in 2014-12 to use local binding for external symbols for -fPIE. Now that we have H.J. Lu's GOTPCRELX for years which mostly nullify the benefit of HAVE_LD_PIE_COPYRELOC, HAVE_LD_PIE_COPYRELOC should retire now. One design goal of -fPIE was to avoid copy relocations. HAVE_LD_PIE