Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-05 Thread Jakub Jelinek
On Mon, Mar 31, 2025 at 03:12:56PM +0200, Richard Biener wrote: > The following fixes ix86_handle_option to properly handle -mno-sse4 > which is always handled as -msse4 with value unset. I've verified > no other OPT_mno_* is left around. > > Bootstrap and regtest running on x86_64-unknown-linux-

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-04 Thread Hongtao Liu
On Mon, Mar 31, 2025 at 9:52 PM Richard Biener wrote: > > On Mon, 31 Mar 2025, Jakub Jelinek wrote: > > > On Mon, Mar 31, 2025 at 03:33:34PM +0200, Richard Biener wrote: > > > On Mon, 31 Mar 2025, Jakub Jelinek wrote: > > > > > > > On Mon, Mar 31, 2025 at 03:12:56PM +0200, Richard Biener wrote: >

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-04 Thread Jakub Jelinek
On Mon, Mar 31, 2025 at 03:51:26PM +0200, Richard Biener wrote: > options entry. Or whether that means ix86_valid_target_attribute_inner_p > should have created OPT_mno_sse4 from -mno-sse4. Or OPT_msse4_1 with value 0. Whatever. I think your patch with keeping OPT_mno_sse4 unmodified (it could

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-01 Thread Richard Biener
On Tue, 1 Apr 2025, Jakub Jelinek wrote: > On Tue, Apr 01, 2025 at 01:36:23PM +0800, Hongtao Liu wrote: > > >Changing ix86_valid_target_attribute_inner_p might be even better because > > >OPT_msse4 is RejectNegative option, so !value for it looks weird. > > msse4 is defined as ix86_opt_isa in ix86

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-01 Thread Hongtao Liu
On Tue, Apr 1, 2025 at 3:56 PM Jakub Jelinek wrote: > > On Tue, Apr 01, 2025 at 01:36:23PM +0800, Hongtao Liu wrote: > > >Changing ix86_valid_target_attribute_inner_p might be even better because > > >OPT_msse4 is RejectNegative option, so !value for it looks weird. > > msse4 is defined as ix86_op

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-01 Thread Jakub Jelinek
On Tue, Apr 01, 2025 at 01:36:23PM +0800, Hongtao Liu wrote: > >Changing ix86_valid_target_attribute_inner_p might be even better because > >OPT_msse4 is RejectNegative option, so !value for it looks weird. > msse4 is defined as ix86_opt_isa in ix86_valid_target_attribute_inner_p > > 1055IX86_

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-03-31 Thread Richard Biener
On Mon, 31 Mar 2025, Jakub Jelinek wrote: > On Mon, Mar 31, 2025 at 03:12:56PM +0200, Richard Biener wrote: > > The following fixes ix86_handle_option to properly handle -mno-sse4 > > which is always handled as -msse4 with value unset. I've verified > > no other OPT_mno_* is left around. > > > >

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-03-31 Thread Richard Biener
On Mon, 31 Mar 2025, Jakub Jelinek wrote: > On Mon, Mar 31, 2025 at 03:33:34PM +0200, Richard Biener wrote: > > On Mon, 31 Mar 2025, Jakub Jelinek wrote: > > > > > On Mon, Mar 31, 2025 at 03:12:56PM +0200, Richard Biener wrote: > > > > The following fixes ix86_handle_option to properly handle -mn

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-03-31 Thread Jakub Jelinek
On Mon, Mar 31, 2025 at 03:33:34PM +0200, Richard Biener wrote: > On Mon, 31 Mar 2025, Jakub Jelinek wrote: > > > On Mon, Mar 31, 2025 at 03:12:56PM +0200, Richard Biener wrote: > > > The following fixes ix86_handle_option to properly handle -mno-sse4 > > > which is always handled as -msse4 with v

[PATCH] target/119549 - fixup handling of -mno-sse4

2025-03-31 Thread Richard Biener
The following fixes ix86_handle_option to properly handle -mno-sse4 which is always handled as -msse4 with value unset. I've verified no other OPT_mno_* is left around. Bootstrap and regtest running on x86_64-unknown-linux-gnu. This error goes back quite some time, I'm not sure how prevalent the