Re: [PATCH] s390: Fix C++14 vs. C++17 ABI incompatibility on s390{, x} [PR94704]

2020-04-27 Thread Andreas Krebbel via Gcc-patches
On 27.04.20 09:36, Jakub Jelinek wrote: > On Mon, Apr 27, 2020 at 08:41:32AM +0200, Andreas Krebbel wrote: >> Ok. Thanks for doing this! > > Thanks, committed. > >> We probably have to look into providing a -Wpsabi warning as well. > > So like this? Untested except on a small testcase. > > 202

Re: [PATCH] s390: Fix C++14 vs. C++17 ABI incompatibility on s390{,x} [PR94704]

2020-04-27 Thread Jakub Jelinek via Gcc-patches
On Mon, Apr 27, 2020 at 08:41:32AM +0200, Andreas Krebbel wrote: > Ok. Thanks for doing this! Thanks, committed. > We probably have to look into providing a -Wpsabi warning as well. So like this? Untested except on a small testcase. 2020-04-27 Jakub Jelinek PR target/94704

Re: [PATCH] s390: Fix C++14 vs. C++17 ABI incompatibility on s390{, x} [PR94704]

2020-04-26 Thread Andreas Krebbel via Gcc-patches
On 26.04.20 14:20, Jakub Jelinek wrote: > Hi! > > The following patch fixes the C++14 vs. C++17 ABI passing incompatibility > on s390x-linux. > > Bootstrapped/regtested on s390x-linux without and with the patch, the > difference being: > -FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_alt.o

[PATCH] s390: Fix C++14 vs. C++17 ABI incompatibility on s390{,x} [PR94704]

2020-04-26 Thread Jakub Jelinek via Gcc-patches
Hi! The following patch fixes the C++14 vs. C++17 ABI passing incompatibility on s390x-linux. Bootstrapped/regtested on s390x-linux without and with the patch, the difference being: -FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_alt.o-cp_compat_y_tst.o execute FAIL: tmpdir-g++.dg-struct