Re: [PING] [PATCH] rust: avoid clobbering LIBS

2024-09-04 Thread Richard Biener
On Tue, Sep 3, 2024 at 8:42 PM Marc wrote: > > Richard Biener writes: > > > On Wed, Aug 28, 2024 at 11:10 AM Marc wrote: > >> > >> Hello, > >> > >> Gentle reminder for this simple autoconf patch :) > > > > OK. > > > > Note that completely wiping LIBS might remove requirements detected earlier, >

Re: [PING] [PATCH] rust: avoid clobbering LIBS

2024-09-03 Thread Marc
Richard Biener writes: > On Wed, Aug 28, 2024 at 11:10 AM Marc wrote: >> >> Hello, >> >> Gentle reminder for this simple autoconf patch :) > > OK. > > Note that completely wiping LIBS might remove requirements detected earlier, > like some systems require explicit -lc for example. I would inste

Re: [PING] [PATCH] rust: avoid clobbering LIBS

2024-08-28 Thread Richard Biener
On Wed, Aug 28, 2024 at 11:10 AM Marc wrote: > > Hello, > > Gentle reminder for this simple autoconf patch :) OK. Note that completely wiping LIBS might remove requirements detected earlier, like some systems require explicit -lc for example. I would instead not clear LIBS here and instead allo

[PING] [PATCH] rust: avoid clobbering LIBS

2024-08-28 Thread Marc
Hello, Gentle reminder for this simple autoconf patch :) Thanks, Marc

Re: [PATCH] rust: avoid clobbering LIBS

2024-08-20 Thread dkm
August 12, 2024 at 4:09 PM, "Arthur Cohen" wrote: > > Hi Marc, > > Patch looks good to me :) Thanks! > Hello, thanks for the Ack :) I'm still waiting for a maintainer review... I've been told this may qualify as "trivial", but again, I would prefer a formal Ack as I'm not really an exper

Re: [PATCH] rust: avoid clobbering LIBS

2024-08-12 Thread Arthur Cohen
Hi Marc, Patch looks good to me :) Thanks! On 8/6/24 18:43, Marc Poulhiès wrote: Save LIBS around calls to AC_SEARCH_LIBS to avoid clobbering $LIBS. ChangeLog: * configure: Regenerate. * configure.ac: Save LIBS around calls to AC_SEARCH_LIBS. Signed-off-by: Marc Poulhiès Rev

[PATCH] rust: avoid clobbering LIBS

2024-08-06 Thread Marc Poulhiès
Save LIBS around calls to AC_SEARCH_LIBS to avoid clobbering $LIBS. ChangeLog: * configure: Regenerate. * configure.ac: Save LIBS around calls to AC_SEARCH_LIBS. Signed-off-by: Marc Poulhiès Reviewed-by: Thomas Schwinge Tested-by: Thomas Schwinge --- Hello, This has already b