Re: [PATCH] rtx_writer: avoid printing trailing default values

2016-11-07 Thread David Malcolm
On Fri, 2016-11-04 at 20:40 +0100, Bernd Schmidt wrote: > On 11/04/2016 08:25 PM, David Malcolm wrote: > > > return m_compact; > > Ok with this one plus a comment. > Thanks. Using m_compact required turning the static function into a (private) member function. For reference, here's

Re: [PATCH] rtx_writer: avoid printing trailing default values

2016-11-04 Thread Bernd Schmidt
On 11/04/2016 08:25 PM, David Malcolm wrote: return m_compact; Ok with this one plus a comment. Bernd

Re: [PATCH] rtx_writer: avoid printing trailing default values

2016-11-04 Thread David Malcolm
On Fri, 2016-11-04 at 19:53 +0100, Bernd Schmidt wrote: > On 11/04/2016 08:14 PM, David Malcolm wrote: > > > > With this, compact dumps omit the trailing (nil) for both regular > > insns > > and for JUMP_INSNs, and omits the surplus newline seen in my > > earlier patch. > > > > It also appears re

Re: [PATCH] rtx_writer: avoid printing trailing default values

2016-11-04 Thread Bernd Schmidt
On 11/04/2016 08:14 PM, David Malcolm wrote: With this, compact dumps omit the trailing (nil) for both regular insns and for JUMP_INSNs, and omits the surplus newline seen in my earlier patch. It also appears removes the trailing (nil) from expr_list. Bootstrap®rtest in progress. OK for trunk

[PATCH] rtx_writer: avoid printing trailing default values

2016-11-04 Thread David Malcolm
On Fri, 2016-11-04 at 18:51 +0100, Bernd Schmidt wrote: > Here's something simpler. Only very lightly tested, but isn't > something > like this all that's needed? Could decide whether to apply it to > expr_list etc. as well. > > Index: print-rtl.c >