Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

On 10/1/23 08:26, Stefan Schulze Frielinghaus wrote: FWIW, I should definitely have caught this hunk earlier -- we've gone the rounds in this same space (GEN_INT vs gen_int_mode) elsewhere. Again, sorry for the long wait. jeff No worries at all. At least I have learned something new :)

Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

On Fri, Sep 29, 2023 at 01:01:57PM -0600, Jeff Law wrote: > > > On 8/10/23 07:04, Stefan Schulze Frielinghaus via Gcc-patches wrote: > > In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I > > completely missed the fact that the normal form of a generated constant for > > a >

Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

On 8/10/23 07:04, Stefan Schulze Frielinghaus via Gcc-patches wrote: In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I completely missed the fact that the normal form of a generated constant for a mode with fewer bits than in HOST_WIDE_INT is a sign extended version of the

Re: PING^5: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

On 9/19/23 10:06, Stefan Schulze Frielinghaus wrote: Since this patch is sitting in the queue for quite some time and (more importantly?) solves a bootstrap problem let me reiterate: While writing the initial commit 7cdd0860949c6c3232e6cff1d7ca37bb5234074c and the subsequent (potential) fix 4

Re: PING^5: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

> This is why I got a bit uncertain and hoped to get some feedback whether > my intuition is correct or not. Meanwhile I also found a comment in > the internals book at "14.7 Constant Expression Types" where we have: > >"Constants generated for modes with fewer bits than in HOST_WIDE_INT >

Re: PING^5: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Since this patch is sitting in the queue for quite some time and (more importantly?) solves a bootstrap problem let me reiterate: While writing the initial commit 7cdd0860949c6c3232e6cff1d7ca37bb5234074c and the subsequent (potential) fix 41ef5a34161356817807be3a2e51fbdbe575ae85 I was not aware of

PING^5: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Ping^5. > > > On Thu, Aug 10, 2023 at 03:04:03PM +0200, Stefan Schulze Frielinghaus > > > wrote: > > > > In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I > > > > completely missed the fact that the normal form of a generated constant > > > > for a > > > > mode with fewer bi

PING^4: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Ping. > > > On Thu, Aug 10, 2023 at 03:04:03PM +0200, Stefan Schulze Frielinghaus > > > wrote: > > > > In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I > > > > completely missed the fact that the normal form of a generated constant > > > > for a > > > > mode with fewer bits

Re: PING^3: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Ping. On Thu, Aug 24, 2023 at 11:31:32AM +0800, Xi Ruoyao wrote: > Ping again. > > On Fri, 2023-08-18 at 13:04 +0200, Stefan Schulze Frielinghaus via > Gcc-patches wrote: > > Ping.  Since this fixes bootstrap problem PR110939 for Loongarch I'm > > pingen this one earlier. > > > > On Thu, Aug 10

[PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Ping. This patch also fixed issue occurred in RISC-V backend: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71 Thanks. juzhe.zh...@rivai.ai

Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Hi Jeff, Can you take a look at the patch? It fixes a bootstrap failure on LoongArch. And in this month 3 related bugzilla tickets have been created (110939, 24, 71). On Thu, 2023-08-10 at 15:04 +0200, Stefan Schulze Frielinghaus via Gcc- patches wrote: > In the former fix in commit 41e

PING^2: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Ping again. On Fri, 2023-08-18 at 13:04 +0200, Stefan Schulze Frielinghaus via Gcc-patches wrote: > Ping.  Since this fixes bootstrap problem PR110939 for Loongarch I'm > pingen this one earlier. > > On Thu, Aug 10, 2023 at 03:04:03PM +0200, Stefan Schulze Frielinghaus wrote: > > In the former f

Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

Ping. Since this fixes bootstrap problem PR110939 for Loongarch I'm pingen this one earlier. On Thu, Aug 10, 2023 at 03:04:03PM +0200, Stefan Schulze Frielinghaus wrote: > In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I > completely missed the fact that the normal form of a

Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

On Sat, Aug 12, 2023 at 09:04:19AM +0800, Xi Ruoyao wrote: > On Thu, 2023-08-10 at 15:04 +0200, Stefan Schulze Frielinghaus via Gcc- > patches wrote: > > In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I > > completely missed the fact that the normal form of a generated constan

Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

On Thu, 2023-08-10 at 15:04 +0200, Stefan Schulze Frielinghaus via Gcc- patches wrote: > In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I > completely missed the fact that the normal form of a generated constant for a > mode with fewer bits than in HOST_WIDE_INT is a sign exte

[PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant

In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I completely missed the fact that the normal form of a generated constant for a mode with fewer bits than in HOST_WIDE_INT is a sign extended version of the actual constant. This even holds true for unsigned constants. Fixed by