Re: [PATCH] rtl: Remove invalid compare simplification [PR117186]

2025-01-13 Thread Tobias Burnus
Andreas Schwab wrote: This breaks m68k: Same issue on GCN, hence I filed https://gcc.gnu.org/PR118418 If I look at the debugging output, see PR, it seems as if the self-test function test_comparisons contains the assumption: FALSE < TRUE but if TRUE is -1, that assumption does not hold (fo

Re: [PATCH] rtl: Remove invalid compare simplification [PR117186]

2025-01-11 Thread Andreas Schwab
This breaks m68k: $ ./xgcc -B./ -xc -nostdinc /dev/null -S -o /dev/null -fself-test=../../gcc/testsuite/selftests ../../gcc/simplify-rtx.cc:8600: test_comparisons: FAIL: ASSERT_RTX_EQ (val, folded) expected: (const_int -1 [0x]) actual: (const_int 0 [0]) cc1: internal compile

Re: [PATCH] rtl: Remove invalid compare simplification [PR117186]

2025-01-10 Thread Richard Sandiford
Richard Biener writes: > On Mon, Jan 6, 2025 at 2:12 PM Richard Sandiford > wrote: >> >> g:d882fe5150fbbeb4e44d007bb4964e5b22373021, posted at >> https://gcc.gnu.org/pipermail/gcc-patches/2000-July/033786.html , >> added code to treat: >> >> (set (reg:CC cc) (compare:CC (gt:M (reg:CC cc) 0) (lt

Re: [PATCH] rtl: Remove invalid compare simplification [PR117186]

2025-01-09 Thread Richard Biener
On Mon, Jan 6, 2025 at 2:12 PM Richard Sandiford wrote: > > g:d882fe5150fbbeb4e44d007bb4964e5b22373021, posted at > https://gcc.gnu.org/pipermail/gcc-patches/2000-July/033786.html , > added code to treat: > > (set (reg:CC cc) (compare:CC (gt:M (reg:CC cc) 0) (lt:M (reg:CC cc) 0))) > > as a nop.

[PATCH] rtl: Remove invalid compare simplification [PR117186]

2025-01-06 Thread Richard Sandiford
g:d882fe5150fbbeb4e44d007bb4964e5b22373021, posted at https://gcc.gnu.org/pipermail/gcc-patches/2000-July/033786.html , added code to treat: (set (reg:CC cc) (compare:CC (gt:M (reg:CC cc) 0) (lt:M (reg:CC cc) 0))) as a nop. This PR shows that that isn't always correct. The compare in the set a