Re: [PATCH] rs6000: Fix check_effective_target_sqrt_insn (PR99352)

2021-03-11 Thread Segher Boessenkool
On Wed, Mar 10, 2021 at 02:06:24AM -0300, Alexandre Oliva wrote: > On Mar 9, 2021, Segher Boessenkool wrote: > > > +return [check_no_compiler_messages powerpc_sqrt object { > > I don't think you really need to assemble this. s/object/assembly/ > would do. Even preprocessing alone would do

Re: [PATCH] rs6000: Fix check_effective_target_sqrt_insn (PR99352)

2021-03-09 Thread Alexandre Oliva
On Mar 9, 2021, Segher Boessenkool wrote: > +return [check_no_compiler_messages powerpc_sqrt object { I don't think you really need to assemble this. s/object/assembly/ would do. Even preprocessing alone would do, but I don't think check_compiler can do that. -- Alexandre Oliva, happy h

[PATCH] rs6000: Fix check_effective_target_sqrt_insn (PR99352)

2021-03-09 Thread Segher Boessenkool
The previous version returned true for all PowerPC. This is incorrect. We only support floating point square root instructions if a) we support floating point instructions at all, and b) we have _ARCH_PPCSQ defined. 2020-03-09 Segher Boessenkool * testsuite/lib/target-supports.exp