Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-26 Thread Peter Bergner
On Wed, 2015-02-25 at 16:22 -0600, Peter Bergner wrote: > On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote: > > On Mon, Feb 23, 2015 at 1:26 PM, Peter Bergner wrote: > > > This is broken on 4.9 and 4.8, so can we get those fixed as well? > > > > Yes, please backport. > > I committed this

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-25 Thread Peter Bergner
On Wed, 2015-02-25 at 21:57 -0500, David Edelsohn wrote: > Okay. Ok, committed as revision 220998 with the following ChangeLog entry: * gcc.target/powerpc/htm-builtin-1.c (dg-do) Change to assemble. (dg-options): Add -save-temps. (dg-final): Add cleanup-saved-temps. I'll a

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-25 Thread David Edelsohn
On Wed, Feb 25, 2015 at 9:42 PM, Peter Bergner wrote: > On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote: >> Again, a testcase is highly encouraged. > > Actually, this additional change to the test case would be enough > to have the assembler catch the bad opcode mnemonic. Should I > just

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-25 Thread Peter Bergner
On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote: > Again, a testcase is highly encouraged. Actually, this additional change to the test case would be enough to have the assembler catch the bad opcode mnemonic. Should I just go ahead and make this change? I still plan on adding a test cas

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-25 Thread Peter Bergner
On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote: > On Mon, Feb 23, 2015 at 1:26 PM, Peter Bergner wrote: > > This is broken on 4.9 and 4.8, so can we get those fixed as well? > > Yes, please backport. I committed this to trunk on Adhemerval's behalf as revision 220992. I'll commit it to

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-23 Thread David Edelsohn
On Mon, Feb 23, 2015 at 1:26 PM, Peter Bergner wrote: > On Fri, 2015-02-20 at 15:43 -0500, David Edelsohn wrote: >> On Fri, Feb 20, 2015 at 12:44 PM, Adhemerval Zanella >> wrote: >> > gcc/ChangeLog: >> > >> > * config/rs6000/htm.md (tcheck): Fix assembly encoding. >> > >> > gcc/testsuite/

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-23 Thread Peter Bergner
On Fri, 2015-02-20 at 15:43 -0500, David Edelsohn wrote: > On Fri, Feb 20, 2015 at 12:44 PM, Adhemerval Zanella > wrote: > > gcc/ChangeLog: > > > > * config/rs6000/htm.md (tcheck): Fix assembly encoding. > > > > gcc/testsuite/ChangeLog > > > > * gcc.target/powerpc/htm-builtin-1.c:

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-20 Thread David Edelsohn
On Fri, Feb 20, 2015 at 12:44 PM, Adhemerval Zanella wrote: > gcc/ChangeLog: > > * config/rs6000/htm.md (tcheck): Fix assembly encoding. > > gcc/testsuite/ChangeLog > > * gcc.target/powerpc/htm-builtin-1.c: Fix tcheck expect value. Okay. Thanks, David

Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-20 Thread Peter Bergner
On Fri, 2015-02-20 at 15:44 -0200, Adhemerval Zanella wrote: > gcc/ChangeLog: > > * config/rs6000/htm.md (tcheck): Fix assembly encoding. > > gcc/testsuite/ChangeLog > > * gcc.target/powerpc/htm-builtin-1.c: Fix tcheck expect value. You are correct that the tcheck insn does not have

[PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-20 Thread Adhemerval Zanella
gcc/ChangeLog: * config/rs6000/htm.md (tcheck): Fix assembly encoding. gcc/testsuite/ChangeLog * gcc.target/powerpc/htm-builtin-1.c: Fix tcheck expect value. --- diff --git a/gcc/config/rs6000/htm.md b/gcc/config/rs6000/htm.md index 2c4689f..79fb740 100644 --- a/gcc/config/rs60