Re: [PATCH] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Segher Boessenkool
On Thu, May 23, 2019 at 08:56:23AM -0500, Bill Schmidt wrote: > On 5/23/19 6:06 AM, Segher Boessenkool wrote: > > On Wed, May 22, 2019 at 06:39:55PM -0500, Bill Schmidt wrote: > >> @@ -26191,6 +26191,10 @@ rs6000_global_entry_point_needed_p (void) > >>if (TARGET_SINGLE_PIC_BASE) > >> retur

Re: [PATCH] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Bill Schmidt
On 5/23/19 6:06 AM, Segher Boessenkool wrote: > Hi! > > On Wed, May 22, 2019 at 06:39:55PM -0500, Bill Schmidt wrote: >> @@ -26191,6 +26191,10 @@ rs6000_global_entry_point_needed_p (void) >>if (TARGET_SINGLE_PIC_BASE) >> return false; >> >> + /* PC-relative functions never generate a gl

Re: [PATCH] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Segher Boessenkool
Hi! On Wed, May 22, 2019 at 06:39:55PM -0500, Bill Schmidt wrote: > @@ -26191,6 +26191,10 @@ rs6000_global_entry_point_needed_p (void) >if (TARGET_SINGLE_PIC_BASE) > return false; > > + /* PC-relative functions never generate a global entry point prologue. */ > + if (rs6000_pcrel_p (

[PATCH] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-22 Thread Bill Schmidt
Hi, Functions using PC-relative addressing do not use a TOC, so there is no need for a global entry point for TOC setup. Ensure we never generate a global entry point, and use a .localentry directive that sets the upper st_other bits to 1. Bootstrapped and tested on powerpc64le-unknown-linux-gnu