Re: [PING^1][PATCH] rs6000: Change bitwise xor to inequality operator [PR106907]

Ping! please review. Thanks & Regards Jeevitha On 16/06/23 9:55 am, Peter Bergner wrote: > On 6/12/23 6:18 AM, P Jeevitha wrote: >> Bitwise xor performed on bool >> is similar to checking inequality. So changed to inequality >> operator (!=) instead of bitwise xor (^). > [snip' >> - if (swa

Re: [PATCH] rs6000: Change bitwise xor to inequality operator [PR106907]

On 6/12/23 6:18 AM, P Jeevitha wrote: > Bitwise xor performed on bool > is similar to checking inequality. So changed to inequality > operator (!=) instead of bitwise xor (^). [snip' > - if (swapped ^ !BYTES_BIG_ENDIAN [snip] > + if (swapped != !BYTES_BIG_ENDIAN I know Andreas mentione

[PATCH] rs6000: Change bitwise xor to inequality operator [PR106907]

PR106907 has few warnings spotted from cppcheck. Here we have warnings for precedence clarification since boolean results are used in bitwise operation. Bitwise xor performed on bool is similar to checking inequality. So changed to inequality operator (!=) instead of bitwise xor (^). And fixed comm