On Tue, 18 Jan 2022, Palmer Dabbelt wrote:
> Yep. Seeing this go by, though, I think there's some English issues with the
> original messages. I'd write it more like this, but I'm never 100% sure on
> these things:
>
>diff --git a/gcc/common/config/riscv/riscv-common.cc
> b/gcc/common/confi
On 1/18/22 23:00, Joseph Myers wrote:
On Tue, 18 Jan 2022, Martin Liška wrote:
@@ -3309,8 +3309,8 @@ riscv_handle_type_attribute (tree *node
ATTRIBUTE_UNUSED, tree name, tree args,
&& strcmp (string, "machine"))
{
warning (OPT_Wattributes,
-
On Tue, 18 Jan 2022, Martin Liška wrote:
> @@ -3309,8 +3309,8 @@ riscv_handle_type_attribute (tree *node
> ATTRIBUTE_UNUSED, tree name, tree args,
> && strcmp (string, "machine"))
> {
> warning (OPT_Wattributes,
> -"argument to %qE attribute is
On Tue, 18 Jan 2022 08:31:12 PST (-0800), gcc-patches@gcc.gnu.org wrote:
Thanks Martin!
Yep. Seeing this go by, though, I think there's some English issues
with the original messages. I'd write it more like this, but I'm never
100% sure on these things:
diff --git a/gcc/common/config/r
Thanks Martin!
On Wed, Jan 19, 2022 at 12:23 AM Martin Liška wrote:
>
> Pushed as pre-approved by Jeff. The patch fixes -Wformat-diag warnings.
>
> Martin
>
> gcc/ChangeLog:
>
> * common/config/riscv/riscv-common.cc (riscv_subset_list::add):
> Wrap keywords with quotes and remove
Pushed as pre-approved by Jeff. The patch fixes -Wformat-diag warnings.
Martin
gcc/ChangeLog:
* common/config/riscv/riscv-common.cc (riscv_subset_list::add):
Wrap keywords with quotes and remove trailing dots.
(riscv_subset_list::parsing_subset_version): Likewise.
