Re: [PATCH] riscv: add mising masking in lrsc expander (PR118137)

2025-01-08 Thread Andreas Schwab
Please fix your git to strip the subject prefix. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] riscv: add mising masking in lrsc expander (PR118137)

2025-01-07 Thread Jeff Law
On 1/7/25 8:37 AM, Andreas Schwab wrote: gcc: PR target/118137 * config/riscv/sync.md ("lrsc_atomic_exchange"): Apply mask to shifted value. gcc/testsuite: PR target/118137 * gcc.dg/atomic/pr118137.c: New. Thanks. I went ahead and pushed this to the t

Re: [PATCH] riscv: add mising masking in lrsc expander (PR118137)

2025-01-07 Thread Kito Cheng
LGTM Patrick O'Neill 於 2025年1月8日 週三 00:12 寫道: > > On 1/7/25 07:37, Andreas Schwab wrote: > > gcc: > > PR target/118137 > > * config/riscv/sync.md ("lrsc_atomic_exchange"): Apply mask > > to shifted value. > > > > gcc/testsuite: > > PR target/118137 > > * gcc.dg/atom

Re: [PATCH] riscv: add mising masking in lrsc expander (PR118137)

2025-01-07 Thread Patrick O'Neill
On 1/7/25 07:37, Andreas Schwab wrote: gcc: PR target/118137 * config/riscv/sync.md ("lrsc_atomic_exchange"): Apply mask to shifted value. gcc/testsuite: PR target/118137 * gcc.dg/atomic/pr118137.c: New. --- Thanks for fixing this - I can't give approva

[PATCH] riscv: add mising masking in lrsc expander (PR118137)

2025-01-07 Thread Andreas Schwab
gcc: PR target/118137 * config/riscv/sync.md ("lrsc_atomic_exchange"): Apply mask to shifted value. gcc/testsuite: PR target/118137 * gcc.dg/atomic/pr118137.c: New. --- gcc/config/riscv/sync.md | 1 + gcc/testsuite/gcc.dg/atomic/pr118137.c |