Re: [PATCH] reload: Adjust comment in find_reloads about subset, not intersection

2022-03-19 Thread Jeff Law via Gcc-patches
On 2/2/2022 8:16 AM, Richard Sandiford via Gcc-patches wrote: Richard Sandiford writes: Hans-Peter Nilsson writes: From: Richard Sandiford Hans-Peter Nilsson via Gcc-patches writes: The mystery isn't so much that there's code mismatching comments or intent, but that this code has been t

Re: [PATCH] reload: Adjust comment in find_reloads about subset, not intersection

2022-02-14 Thread Hans-Peter Nilsson via Gcc-patches
Rather than assuming it's seen and thought not worth the bother, I'll go with not-seen, so: Jeff: ping. A little love for reload, comment-wise, before it's put down! > From: Richard Sandiford > CC: "gcc-patches@gcc.gnu.org" , "j...@tachyum.com" > > Date: Wed, 2 Feb 2022 16:16:14 +0100 >

Re: [PATCH] reload: Adjust comment in find_reloads about subset, not intersection

2022-02-02 Thread Richard Sandiford via Gcc-patches
Richard Sandiford writes: > Hans-Peter Nilsson writes: >>> From: Richard Sandiford >>> Hans-Peter Nilsson via Gcc-patches writes: >>> > The mystery isn't so much that there's code mismatching comments or >>> > intent, but that this code has been there "forever". There has been a >>> > function

Re: [PATCH] reload: Adjust comment in find_reloads about subset, not intersection

2022-02-02 Thread Richard Sandiford via Gcc-patches
Hans-Peter Nilsson writes: >> From: Richard Sandiford >> Hans-Peter Nilsson via Gcc-patches writes: >> > The mystery isn't so much that there's code mismatching comments or >> > intent, but that this code has been there "forever". There has been a >> > function reg_classes_intersect_p, in gcc s

[PATCH] reload: Adjust comment in find_reloads about subset, not intersection

2022-02-01 Thread Hans-Peter Nilsson via Gcc-patches
> From: Richard Sandiford > Hans-Peter Nilsson via Gcc-patches writes: > > The mystery isn't so much that there's code mismatching comments or > > intent, but that this code has been there "forever". There has been a > > function reg_classes_intersect_p, in gcc since r0-54, even *before* > > the