Re: [PATCH] phiopt: Reject hot/cold predictors for early phiopt [PR117935]

2025-01-11 Thread Richard Biener
> Am 11.01.2025 um 11:29 schrieb Andrew Pinski : > > On Sat, Jan 11, 2025 at 2:10 AM Richard Biener > wrote: >> >> >> Am 11.01.2025 um 09:49 schrieb Andrew Pinski : >>> >>> In this case, early phiopt would get rid of the user provided predicator >>> for hot/cold as it would remove t

Re: [PATCH] phiopt: Reject hot/cold predictors for early phiopt [PR117935]

2025-01-11 Thread Andrew Pinski
On Sat, Jan 11, 2025 at 2:10 AM Richard Biener wrote: > > > > > Am 11.01.2025 um 09:49 schrieb Andrew Pinski : > > > > In this case, early phiopt would get rid of the user provided predicator > > for hot/cold as it would remove the basic blocks. The easiest and best > > option is > > for early p

Re: [PATCH] phiopt: Reject hot/cold predictors for early phiopt [PR117935]

2025-01-11 Thread Richard Biener
> Am 11.01.2025 um 09:49 schrieb Andrew Pinski : > > In this case, early phiopt would get rid of the user provided predicator > for hot/cold as it would remove the basic blocks. The easiest and best option > is > for early phi-opt don't do phi-opt if the middle basic-block(s) have either > a

[PATCH] phiopt: Reject hot/cold predictors for early phiopt [PR117935]

2025-01-11 Thread Andrew Pinski
In this case, early phiopt would get rid of the user provided predicator for hot/cold as it would remove the basic blocks. The easiest and best option is for early phi-opt don't do phi-opt if the middle basic-block(s) have either a hot or cold predict statement. Then after inlining, jump threading