Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-20 Thread Tobias Burnus
See patch and thread at https://gcc.gnu.org/pipermail/gcc-patches/2020-October/556570.html Tobias On 10/20/20 3:51 PM, David Edelsohn via Gcc-patches wrote: This patch broke bootstrap on AIX. /nasfarm/edelsohn/src/src/libgomp/target.c: In function 'gomp_target_init.part.': /nasfarm/edelsohn/sr

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-20 Thread David Edelsohn via Gcc-patches
This patch broke bootstrap on AIX. /nasfarm/edelsohn/src/src/libgomp/target.c: In function 'gomp_target_init.part.': /nasfarm/edelsohn/src/src/libgomp/target.c:3367:45: error: array subscript [-19877956975980120, 19877956975980120] is outside array bounds of 'struct gomp_device_descr[0]' [-Werror=

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-15 Thread Jakub Jelinek via Gcc-patches
On Thu, Oct 15, 2020 at 10:38:56AM +0100, Kwok Cheung Yeung wrote: > Okay to apply this patch? Ok, thanks. > commit 3f6f8808f74598e274bfb8245c08a5428ee1b3fd > Author: Kwok Cheung Yeung > Date: Thu Oct 15 02:32:09 2020 -0700 > > Amend documentation for omp_get_max_active_levels and > omp_

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-15 Thread Kwok Cheung Yeung
On 14/10/2020 9:20 am, Jakub Jelinek wrote: On Tue, Oct 13, 2020 at 07:05:10PM +0100, Kwok Cheung Yeung wrote: +* omp_get_supported_active_levels:: Maxiumum number of active levels supported Sorry for not catching it during review, but there is a typo above. Fixed with patch below, committed

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-14 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 13, 2020 at 07:05:10PM +0100, Kwok Cheung Yeung wrote: > +* omp_get_supported_active_levels:: Maxiumum number of active levels > supported Sorry for not catching it during review, but there is a typo above. Fixed with patch below, committed to trunk. > +@node omp_get_supported_activ

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-13 Thread Kwok Cheung Yeung
Now committed to trunk with the suggested fixes. Thanks for the quick review. Kwok On 13/10/2020 7:36 pm, Jakub Jelinek wrote: I'd suggest to #define gomp_supported_active_levels INT_MAX in libgomp.h and leave out the const variable. Another possibility is an enumerator, but we don't include

Re: [PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-13 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 13, 2020 at 07:05:10PM +0100, Kwok Cheung Yeung wrote: > --- a/libgomp/env.c > +++ b/libgomp/env.c > @@ -73,7 +73,8 @@ struct gomp_task_icv gomp_global_icv = { >.target_data = NULL > }; > > -unsigned long gomp_max_active_levels_var = INT_MAX; > +const unsigned long gomp_supported

[PATCH] openmp: Add support for omp_get_supported_active_levels

2020-10-13 Thread Kwok Cheung Yeung
Hello This adds support for the omp_get_supported_active_levels OpenMP runtime routine, first introduced in the 5.0 standard. This routine returns the maximum level of nested active parallel regions supported on a particular implementation of OpenMP, and the current maximum number cannot be se