Re: [PATCH] noncontiguous ifcombine: skip marking of non-SSA_NAMEs [PR117915]

2024-12-18 Thread Alexandre Oliva
On Dec 17, 2024, Alexandre Oliva wrote: > On Dec 17, 2024, Sam James wrote: >>> +/* { dg-options "-O3 -fno-tree-copy-prop -fno-tree-vrp" */ >> Missing closing '}'. > Thanks, I've fixed that, and retested. Here's the consolidated patch what I've just installed. noncontiguous ifcombine: skip

Re: [PATCH] noncontiguous ifcombine: skip marking of non-SSA_NAMEs [PR117915]

2024-12-17 Thread Richard Biener
> Am 17.12.2024 um 14:35 schrieb Alexandre Oliva : > >  > When ifcombine_mark_ssa_name is called directly, rather than by > ifcombine_mark_ssa_name_walk, we need to check that name is an > SSA_NAME at the caller or in the function itself. For convenience and > safety, I'm moving the checks fr

Re: [PATCH] noncontiguous ifcombine: skip marking of non-SSA_NAMEs [PR117915]

2024-12-17 Thread Alexandre Oliva
On Dec 17, 2024, Sam James wrote: >> +/* { dg-options "-O3 -fno-tree-copy-prop -fno-tree-vrp" */ > Missing closing '}'. Thanks, I've fixed that, and retested. -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Eng

Re: [PATCH] noncontiguous ifcombine: skip marking of non-SSA_NAMEs [PR117915]

2024-12-17 Thread Sam James
Alexandre Oliva writes: > When ifcombine_mark_ssa_name is called directly, rather than by > ifcombine_mark_ssa_name_walk, we need to check that name is an > SSA_NAME at the caller or in the function itself. For convenience and > safety, I'm moving the checks from _walk to the implementation prop

[PATCH] noncontiguous ifcombine: skip marking of non-SSA_NAMEs [PR117915]

2024-12-17 Thread Alexandre Oliva
When ifcombine_mark_ssa_name is called directly, rather than by ifcombine_mark_ssa_name_walk, we need to check that name is an SSA_NAME at the caller or in the function itself. For convenience and safety, I'm moving the checks from _walk to the implementation proper. Regstrapped on x86_64-linux