Re: [PATCH] musl: use correct long double abi by default

2019-11-17 Thread Andreas Krebbel
On 15.11.19 19:58, Szabolcs Nagy wrote: > On 15/11/2019 18:15, Segher Boessenkool wrote: >> On Fri, Nov 15, 2019 at 06:03:25PM +, Szabolcs Nagy wrote: >>> i'm fine with that, it means the --with-long-double-128 >>> switch does not work on *-musl, >> >> I thought that is what you wanted to do.

Re: [PATCH] musl: use correct long double abi by default

2019-11-15 Thread Szabolcs Nagy
On 15/11/2019 19:22, Segher Boessenkool wrote: > On Fri, Nov 15, 2019 at 06:58:24PM +, Szabolcs Nagy wrote: >> 2019-11-15 Szabolcs Nagy >> >> * configure.ac (gcc_cv_target_ldbl128): Set for *-musl* targets. > > That is not what the patch does. It sets it to yes for s390*-linux-musl*,

Re: [PATCH] musl: use correct long double abi by default

2019-11-15 Thread Rich Felker
On Fri, Nov 15, 2019 at 01:22:20PM -0600, Segher Boessenkool wrote: > On Fri, Nov 15, 2019 at 06:58:24PM +, Szabolcs Nagy wrote: > > 2019-11-15 Szabolcs Nagy > > > > * configure.ac (gcc_cv_target_ldbl128): Set for *-musl* targets. > > That is not what the patch does. It sets it to yes

Re: [PATCH] musl: use correct long double abi by default

2019-11-15 Thread Segher Boessenkool
On Fri, Nov 15, 2019 at 06:58:24PM +, Szabolcs Nagy wrote: > 2019-11-15 Szabolcs Nagy > > * configure.ac (gcc_cv_target_ldbl128): Set for *-musl* targets. That is not what the patch does. It sets it to yes for s390*-linux-musl*, it sets it to no for powerpc*-*-linux-musl*, and it do

Re: [PATCH] musl: use correct long double abi by default

2019-11-15 Thread Szabolcs Nagy
On 15/11/2019 18:15, Segher Boessenkool wrote: > On Fri, Nov 15, 2019 at 06:03:25PM +, Szabolcs Nagy wrote: >> i'm fine with that, it means the --with-long-double-128 >> switch does not work on *-musl, > > I thought that is what you wanted to do. If you just want to change the > default, do t

Re: [PATCH] musl: use correct long double abi by default

2019-11-15 Thread Segher Boessenkool
On Fri, Nov 15, 2019 at 06:03:25PM +, Szabolcs Nagy wrote: > On 15/11/2019 17:48, Segher Boessenkool wrote: > > I think it would be much more readable and maintainable if you did > > something like > > > > case "$target" in > > powerpc*-*-linux-musl) > > gcc_cv_target_ldbl128=no > >

Re: [PATCH] musl: use correct long double abi by default

2019-11-15 Thread Szabolcs Nagy
On 15/11/2019 17:48, Segher Boessenkool wrote: > On Fri, Nov 15, 2019 at 05:26:41PM +, Szabolcs Nagy wrote: >> On powerpc and s390x the musl ABI requires 64 bit and 128 bit long >> double respectively, so adjust the default. >> >> gcc/ChangeLog: >> >> 2019-11-15 Szabolcs Nagy >> >> * co

Re: [PATCH] musl: use correct long double abi by default

2019-11-15 Thread Segher Boessenkool
On Fri, Nov 15, 2019 at 05:26:41PM +, Szabolcs Nagy wrote: > On powerpc and s390x the musl ABI requires 64 bit and 128 bit long > double respectively, so adjust the default. > > gcc/ChangeLog: > > 2019-11-15 Szabolcs Nagy > > * configure.ac: Set gcc_cv_target_ldbl128 for musl target

[PATCH] musl: use correct long double abi by default

2019-11-15 Thread Szabolcs Nagy
On powerpc and s390x the musl ABI requires 64 bit and 128 bit long double respectively, so adjust the default. gcc/ChangeLog: 2019-11-15 Szabolcs Nagy * configure.ac: Set gcc_cv_target_ldbl128 for musl targets. * configure: Regenerate. diff --git a/gcc/configure b/gcc/configu