[PING][PATCH] make rich_location safe to copy

2021-06-22 Thread Martin Sebor via Gcc-patches
Ping: David, I'm still looking for approval of the semi_embedded_vec change in the originally posted patch (independent of the already approved subsequent change to rich_location). https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572845.html On 6/15/21 7:48 PM, Martin Sebor wrote: While debu

Re: [PATCH] make rich_location safe to copy

2021-06-16 Thread David Malcolm via Gcc-patches
On Wed, 2021-06-16 at 11:21 -0600, Martin Sebor wrote: > On 6/16/21 10:35 AM, Jason Merrill wrote: > > On 6/16/21 12:11 PM, Martin Sebor wrote: > > > On 6/16/21 9:06 AM, David Malcolm wrote: > > > > On Wed, 2021-06-16 at 08:52 -0600, Martin Sebor wrote: > > > > > On 6/16/21 6:38 AM, David Malcolm w

Re: [PATCH] make rich_location safe to copy

2021-06-16 Thread Martin Sebor via Gcc-patches
On 6/16/21 10:35 AM, Jason Merrill wrote: On 6/16/21 12:11 PM, Martin Sebor wrote: On 6/16/21 9:06 AM, David Malcolm wrote: On Wed, 2021-06-16 at 08:52 -0600, Martin Sebor wrote: On 6/16/21 6:38 AM, David Malcolm wrote: On Tue, 2021-06-15 at 19:48 -0600, Martin Sebor wrote: Thanks for writin

Re: [PATCH] make rich_location safe to copy

2021-06-16 Thread Jason Merrill via Gcc-patches
On 6/16/21 12:11 PM, Martin Sebor wrote: On 6/16/21 9:06 AM, David Malcolm wrote: On Wed, 2021-06-16 at 08:52 -0600, Martin Sebor wrote: On 6/16/21 6:38 AM, David Malcolm wrote: On Tue, 2021-06-15 at 19:48 -0600, Martin Sebor wrote: Thanks for writing the patch. While debugging locations I

Re: [PATCH] make rich_location safe to copy

2021-06-16 Thread Martin Sebor via Gcc-patches
On 6/16/21 9:06 AM, David Malcolm wrote: On Wed, 2021-06-16 at 08:52 -0600, Martin Sebor wrote: On 6/16/21 6:38 AM, David Malcolm wrote: On Tue, 2021-06-15 at 19:48 -0600, Martin Sebor wrote: Thanks for writing the patch. While debugging locations I noticed the semi_embedded_vec template in

Re: [PATCH] make rich_location safe to copy

2021-06-16 Thread David Malcolm via Gcc-patches
On Wed, 2021-06-16 at 08:52 -0600, Martin Sebor wrote: > On 6/16/21 6:38 AM, David Malcolm wrote: > > On Tue, 2021-06-15 at 19:48 -0600, Martin Sebor wrote: > > > > Thanks for writing the patch. > > > > > While debugging locations I noticed the semi_embedded_vec template > > > in line-map.h doesn

Re: [PATCH] make rich_location safe to copy

2021-06-16 Thread Martin Sebor via Gcc-patches
On 6/16/21 6:38 AM, David Malcolm wrote: On Tue, 2021-06-15 at 19:48 -0600, Martin Sebor wrote: Thanks for writing the patch. While debugging locations I noticed the semi_embedded_vec template in line-map.h doesn't declare a copy ctor or copy assignment, but is being copied in a couple of plac

Re: [PATCH] make rich_location safe to copy

2021-06-16 Thread David Malcolm via Gcc-patches
On Tue, 2021-06-15 at 19:48 -0600, Martin Sebor wrote: Thanks for writing the patch. > While debugging locations I noticed the semi_embedded_vec template > in line-map.h doesn't declare a copy ctor or copy assignment, but > is being copied in a couple of places in the C++ parser (via > gcc_rich_l

[PATCH] make rich_location safe to copy

2021-06-15 Thread Martin Sebor via Gcc-patches
While debugging locations I noticed the semi_embedded_vec template in line-map.h doesn't declare a copy ctor or copy assignment, but is being copied in a couple of places in the C++ parser (via gcc_rich_location). It gets away with it most likely because it never grows beyond the embedded buffer.