Re: [PATCH] lower-bitint: Handle INTEGER_CST rhs1 in handle_cast [PR113462]

2024-01-22 Thread Richard Biener
On Mon, 22 Jan 2024, Jakub Jelinek wrote: > On Mon, Jan 22, 2024 at 11:27:52AM +0100, Richard Biener wrote: > > We run into > > > > static tree > > native_interpret_int (tree type, const unsigned char *ptr, int len) > > { > > ... > > if (total_bytes > len > > || total_bytes * BITS_PER_UN

Re: [PATCH] lower-bitint: Handle INTEGER_CST rhs1 in handle_cast [PR113462]

2024-01-22 Thread Jakub Jelinek
On Mon, Jan 22, 2024 at 11:27:52AM +0100, Richard Biener wrote: > We run into > > static tree > native_interpret_int (tree type, const unsigned char *ptr, int len) > { > ... > if (total_bytes > len > || total_bytes * BITS_PER_UNIT > HOST_BITS_PER_DOUBLE_INT) > return NULL_TREE; > > O

Re: [PATCH] lower-bitint: Handle INTEGER_CST rhs1 in handle_cast [PR113462]

2024-01-20 Thread Jakub Jelinek
On Sat, Jan 20, 2024 at 12:11:10PM +0100, Richard Biener wrote: > > The following patch ICEs because fre3 leaves around unfolded > > _1 = VIEW_CONVERT_EXPR<_BitInt(129)>(0); > > Hmm, const_unop should handle this, I suppose either we fail to convert this > to a NOP_EXPR or native encode/interpre

Re: [PATCH] lower-bitint: Handle INTEGER_CST rhs1 in handle_cast [PR113462]

2024-01-20 Thread Richard Biener
> Am 20.01.2024 um 10:39 schrieb Jakub Jelinek : > > Hi! > > The following patch ICEs because fre3 leaves around unfolded > _1 = VIEW_CONVERT_EXPR<_BitInt(129)>(0); Hmm, const_unop should handle this, I suppose either we fail to convert this to a NOP_EXPR or native encode/interpret do not

[PATCH] lower-bitint: Handle INTEGER_CST rhs1 in handle_cast [PR113462]

2024-01-20 Thread Jakub Jelinek
Hi! The following patch ICEs because fre3 leaves around unfolded _1 = VIEW_CONVERT_EXPR<_BitInt(129)>(0); statement and in handle_cast I was expecting just SSA_NAMEs for the large/huge _BitInt to large/huge _BitInt casts; INTEGER_CST is something we can handle in that case exactly the same, as t