Re: [PATCH] libsupc++: Fix UB terminating on foreign exception

2024-04-09 Thread Julia DeMille
I would like to move forward on this patch. Are there any concerns, or just the formatting of the patch, that needs to be addressed?

Re: [PATCH] libsupc++: Fix UB terminating on foreign exception

2024-01-15 Thread Julia DeMille
Some more info: On 2024-01-14 21:39, Julia DeMille wrote: I've gotten this to work, and run into an unexpected situation. Something about the personality routine is causing a SIGABRT. Investigating further. This occurs due to an assertion in _Unwind_SetGR. Seemingly, the compiler intrinsic `__b

Re: [PATCH] libsupc++: Fix UB terminating on foreign exception

2024-01-14 Thread Julia DeMille
On 2024-01-14 18:51, Julia DeMille wrote: I'm unsure if my patch actually fixes it with this demo -- I need to work out how to use a patched GCC without installing it on my system, but without it breaking from not having things it expects to exist on the system. I've gotten this to work, and

Re: [PATCH] libsupc++: Fix UB terminating on foreign exception

2024-01-14 Thread Julia DeMille
On 2024-01-14 01:52, Jonathan Wakely wrote: The reason for this is that the ChangeLog files are auto-generated from the git commit messages, not edited by hand. Patches to those files rarely apply cleanly anyway, because they change so frequently that patches are stale almost immediately. Makes

Re: [PATCH] libsupc++: Fix UB terminating on foreign exception

2024-01-13 Thread Jonathan Wakely
On Sun, 14 Jan 2024, 01:36 Julia DeMille, wrote: > On 1/13/24 19:17, Andrew Pinski wrote: > > 2 things, changelogs go into the email message rather than directly as > > part of the patch., > The reason for this is that the ChangeLog files are auto-generated from the git commit messages, not edit

Re: [PATCH] libsupc++: Fix UB terminating on foreign exception

2024-01-13 Thread Julia DeMille
On 1/13/24 19:17, Andrew Pinski wrote: 2 things, changelogs go into the email message rather than directly as part of the patch., Apologies. I have prepared a revised patch, and will send it when applicable. Second I wonder if you could add a multiple language testcase using GNU objective-C

Re: [PATCH] libsupc++: Fix UB terminating on foreign exception

2024-01-13 Thread Andrew Pinski
On Sat, Jan 13, 2024 at 5:10 PM Julia DeMille wrote: > > Currently, when std::terminate() is called with a foreign exception > active, since nothing in the path checks whether the exception matches > the `GNUCC++\0` personality, a foreign exception can go into the verbose > terminate handler, and

[PATCH] libsupc++: Fix UB terminating on foreign exception

2024-01-13 Thread Julia DeMille
Currently, when std::terminate() is called with a foreign exception active, since nothing in the path checks whether the exception matches the `GNUCC++\0` personality, a foreign exception can go into the verbose terminate handler, and get treated as though it were a C++ exception. Reflection is at