Re: [PATCH] libstdc++: Make sure iterator_traits is populated

2020-02-10 Thread Patrick Palka
On Mon, 10 Feb 2020, Jonathan Wakely wrote: > On 07/02/20 13:59 -0500, Patrick Palka wrote: > > Since basic_istream_view::iterator is neither a cpp17 iterator (because it's > > move-only) nor does it define all four of the types {difference_type, > > value_type, reference, iterator_category}, then

Re: [PATCH] libstdc++: Make sure iterator_traits is populated

2020-02-10 Thread Jonathan Wakely
On 07/02/20 13:59 -0500, Patrick Palka wrote: Since basic_istream_view::iterator is neither a cpp17 iterator (because it's move-only) nor does it define all four of the types {difference_type, value_type, reference, iterator_category}, then by the rule in [iterator.traits], its iterator_traits ha

[PATCH] libstdc++: Make sure iterator_traits is populated

2020-02-07 Thread Patrick Palka
Since basic_istream_view::iterator is neither a cpp17 iterator (because it's move-only) nor does it define all four of the types {difference_type, value_type, reference, iterator_category}, then by the rule in [iterator.traits], its iterator_traits has no members. More concretely this means that i