Re: [PATCH] libiberty: writeargv: Simplify function error mode.

On 6/6/23 02:44, Costas Argyris wrote: You are right, this is also a remnant of the old function design that I completely missed.    Here is the follow-up patch for that. Thanks for pointing it out. Costas On Tue, 6 Jun 2023 at 04:12, Jeff Law > wrote:

Re: [PATCH] libiberty: writeargv: Simplify function error mode.

You are right, this is also a remnant of the old function design that I completely missed.Here is the follow-up patch for that. Thanks for pointing it out. Costas On Tue, 6 Jun 2023 at 04:12, Jeff Law wrote: > > > On 6/5/23 08:37, Costas Argyris via Gcc-patches wrote: > > writeargv can be

Re: [PATCH] libiberty: writeargv: Simplify function error mode.

On 6/5/23 08:37, Costas Argyris via Gcc-patches wrote: writeargv can be simplified by getting rid of the error exit mode that was only relevant many years ago when the function used to open the file descriptor internally. [ ... ] Thanks. I've pushed this to the trunk. You could (as a follow

[PATCH] libiberty: writeargv: Simplify function error mode.

Subject: [PATCH] libiberty: writeargv: Simplify function error mode. The goto-based error mode was based on a previous version of the function where it was responsible for opening the file, so it had to close it upon any exit: https://inbox.sourceware.org/gcc-patches/20070417200340.gm9