Re: [PATCH] libiberty: Fix C89-isms in configure tests

2022-10-18 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 18, 2022 at 04:14:53PM +0200, Florian Weimer wrote: > * Jakub Jelinek: > > > On Tue, Oct 18, 2022 at 04:06:17PM +0200, Florian Weimer wrote: > >> By the way, the stack direction test currently gives incorrect results > >> on x86-64 due to -O2 and address comparison of unrelated objects

Re: [PATCH] libiberty: Fix C89-isms in configure tests

2022-10-18 Thread Florian Weimer via Gcc-patches
* Jakub Jelinek: > On Tue, Oct 18, 2022 at 04:06:17PM +0200, Florian Weimer wrote: >> By the way, the stack direction test currently gives incorrect results >> on x86-64 due to -O2 and address comparison of unrelated objects. I >> assume this doesn't matter because we don't use it on compilers th

Re: [PATCH] libiberty: Fix C89-isms in configure tests

2022-10-18 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 18, 2022 at 04:06:17PM +0200, Florian Weimer wrote: > By the way, the stack direction test currently gives incorrect results > on x86-64 due to -O2 and address comparison of unrelated objects. I > assume this doesn't matter because we don't use it on compilers that > support alloca nat

Re: [PATCH] libiberty: Fix C89-isms in configure tests

2022-10-18 Thread Florian Weimer via Gcc-patches
* Jakub Jelinek: > On Tue, Oct 18, 2022 at 12:05:49PM +0200, Florian Weimer via Gcc-patches > wrote: >> libiberty/ >> >> * acinclude.m4 (check for working strncmp): Add missing >> int return type and parameter list to the definition of main. >> Include for string functions. Avoi

Re: [PATCH] libiberty: Fix C89-isms in configure tests

2022-10-18 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 18, 2022 at 12:05:49PM +0200, Florian Weimer via Gcc-patches wrote: > libiberty/ > > * acinclude.m4 (check for working strncmp): Add missing > int return type and parameter list to the definition of main. > Include for string functions. Avoid calling > undecla

[PATCH] libiberty: Fix C89-isms in configure tests

2022-10-18 Thread Florian Weimer via Gcc-patches
libiberty/ * acinclude.m4 (check for working strncmp): Add missing int return type and parameter list to the definition of main. Include for string functions. Avoid calling undeclared exit function. (stack direction for C alloca): Avoid calling undeclared