On Thu, 2024-02-15 at 14:14 -0500, Antoni Boucher wrote:
> It's OK to merge even though it touches files outside of the jit
> directory and we're in stage 4?
> Or do we need some kind of approval?
I think this patch is sufficiently low-risk that you can go ahead and
merge it.
Dave
>
> On Thu, 2
It's OK to merge even though it touches files outside of the jit
directory and we're in stage 4?
Or do we need some kind of approval?
On Thu, 2024-02-15 at 10:35 -0500, David Malcolm wrote:
> On Thu, 2024-02-08 at 17:09 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch fixes the bug 113842.
> >
On Thu, 2024-02-08 at 17:09 -0500, Antoni Boucher wrote:
> Hi.
> This patch fixes the bug 113842.
> I cannot yet add a test with this patch since it requires using
> try/catch which is not yet merged in master.
> Thanks for the review.
Thanks; patch looks good for trunk, assuming you've tested it
David: Ping.
On Thu, 2024-02-08 at 17:09 -0500, Antoni Boucher wrote:
> Hi.
> This patch fixes the bug 113842.
> I cannot yet add a test with this patch since it requires using
> try/catch which is not yet merged in master.
> Thanks for the review.
-0500
Subject: [PATCH] libgccjit: Clear pending_assemble_externals_processed
Without this patch, code using exception handling will fail the
following assert in the function assemble_external_libcall in varasm.cc:
gcc_assert (!pending_assemble_externals_processed)
gcc/ChangeLog:
PR jit/113842
