Re: [PATCH] libgccjit: Add vector permutation and vector access operations

2024-11-19 Thread David Malcolm
On Thu, 2023-11-30 at 17:16 -0500, Antoni Boucher wrote: > All of these are fixed in this new patch. > Thanks for the review. Thanks for the updated patch. I had said "OK with those fixed" on the older version and it looks like you have indeed fixed the issues I noticed, so this updated patch is

Re: [PATCH] libgccjit: Add vector permutation and vector access operations

2024-02-17 Thread Antoni Boucher
David: Ping. On Fri, 2024-01-19 at 15:21 -0500, Antoni Boucher wrote: > David: Ping. > > On Thu, 2023-11-30 at 17:16 -0500, Antoni Boucher wrote: > > All of these are fixed in this new patch. > > Thanks for the review. > > > > On Mon, 2023-11-20 at 18:05 -0500, David Malcolm wrote: > > > On Fri,

Re: [PATCH] libgccjit: Add vector permutation and vector access operations

2024-01-19 Thread Antoni Boucher
David: Ping. On Thu, 2023-11-30 at 17:16 -0500, Antoni Boucher wrote: > All of these are fixed in this new patch. > Thanks for the review. > > On Mon, 2023-11-20 at 18:05 -0500, David Malcolm wrote: > > On Fri, 2023-11-17 at 17:36 -0500, Antoni Boucher wrote: > > > Hi. > > > This patch adds a vec

Re: [PATCH] libgccjit: Add vector permutation and vector access operations

2023-11-30 Thread Antoni Boucher
ue *elements1, > > + gcc_jit_rvalue *elements2, > > + gcc_jit_rvalue *mask) > > +{ > > +  RETURN_NULL_IF_FAIL (ctxt, NULL, loc, "NULL ctxt"); > > +  JIT_LOG_FUNC (ctxt->get_logger ()); > > + > >

Re: [PATCH] libgccjit: Add vector permutation and vector access operations

2023-11-20 Thread David Malcolm
On Fri, 2023-11-17 at 17:36 -0500, Antoni Boucher wrote: > Hi. > This patch adds a vector permutation and vector access operations > (bug > 112602). > > This was split from this patch: > https://gcc.gnu.org/pipermail/jit/2023q1/001606.html > Thanks for the patch. Overall, looks good, but 3 mino

[PATCH] libgccjit: Add vector permutation and vector access operations

2023-11-17 Thread Antoni Boucher
, 17 Nov 2023 17:23:28 -0500 Subject: [PATCH] libgccjit: Add vector permutation and vector access operations gcc/jit/ChangeLog: PR jit/112602 * docs/topics/compatibility.rst (LIBGCCJIT_ABI_26): New ABI tag. * docs/topics/expressions.rst: Document gcc_jit_context_new_rvalue_vector_perm and