Re: [PATCH] libgcc: refer to pthread_create, not pthread_cancel

2012-01-27 Thread Roland McGrath
I see. There certainly should have been a comment in the code about why pthread_cancel was chosen. I still think it's a particularly poor choice. For glibc, I think pthread_getspecific or pthread_key_create are better choices. Those are much smaller functions that don't bring very much dead cod

Re: [PATCH] libgcc: refer to pthread_create, not pthread_cancel

2012-01-26 Thread Jakub Jelinek
On Thu, Jan 26, 2012 at 05:07:38PM -0800, Roland McGrath wrote: > What do folks think about this change? It obviously should have no effect > whatsoever on builds not using glibc. I'm pretty confident that it won't > have any bad effect on a build using any extant version of glibc that had > pthr

[PATCH] libgcc: refer to pthread_create, not pthread_cancel

2012-01-26 Thread Roland McGrath
For GNU systems, the fact that libgcc/libstdc++ refers to pthread_cancel is utterly bizarre. I don't know of any rationale for this that has ever applied to glibc. AFAICT the choice was made based on the foibles of various non-glibc systems. In practice, things are working fine on GNU systems no