Re: [PATCH] libcpp: Further fixes for incorrect line numbers in large files [PR120061]

2025-05-06 Thread Jason Merrill
On 5/6/25 6:49 AM, Jakub Jelinek wrote: Hi! The backport of the PR108900 fix to 14 branch broke building chromium because static_assert (__LINE__ == expected_line_number, ""); now triggers as the __LINE__ values are off by one. This isn't the case on the trunk and 15 branch because we've switche

Re: [14 PATCH] libcpp: Further fixes for incorrect line numbers in large files [PR120061]

2025-05-06 Thread Richard Biener
On Tue, 6 May 2025, Jakub Jelinek wrote: > Hi! > > Here is the 14 branch version of the PR120061 fix I've just posted > for 16/15. > The differences from the earlier patch are all caused by the > 32-bit location_t on the branch instead of 64-bit location_t that > 16/15 has. > So, it needs 1 << wh

[14 PATCH] libcpp: Further fixes for incorrect line numbers in large files [PR120061]

2025-05-06 Thread Jakub Jelinek
Hi! Here is the 14 branch version of the PR120061 fix I've just posted for 16/15. The differences from the earlier patch are all caused by the 32-bit location_t on the branch instead of 64-bit location_t that 16/15 has. So, it needs 1 << whatever instead of loc_one << whatever in the sources, and

[PATCH] libcpp: Further fixes for incorrect line numbers in large files [PR120061]

2025-05-06 Thread Jakub Jelinek
Hi! The backport of the PR108900 fix to 14 branch broke building chromium because static_assert (__LINE__ == expected_line_number, ""); now triggers as the __LINE__ values are off by one. This isn't the case on the trunk and 15 branch because we've switched to 64-bit location_t and so one actually