Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Koning, Paul via Gcc-patches
> On Jan 12, 2022, at 1:13 PM, Hans-Peter Nilsson via Gcc-patches > wrote: > >> ... > I recall comments about code quality regressions. Are there > actual numbers? (Preferably from around the transition > time, because I bet targets still supporting "-mlra" have > regressed on the reload si

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Maciej W. Rozycki
On Wed, 12 Jan 2022, Richard Biener via Gcc-patches wrote: > > So in theory it might be just pulling the switch for some? That is, > > removing their definition of TARGET_LRA_P which then defaults > > to true? > > I can confirm it works for visium which builds after such change and > can compile

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jeff Law via Gcc-patches > Date: Wed, 12 Jan 2022 16:58:50 +0100 > On 1/12/2022 8:00 AM, Richard Biener wrote: > > On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov > > wrote: > >> > >> On 2022-01-12 03:47, Richard Biener wrote: > >>> On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jeff Law via Gcc-patches > Date: Wed, 12 Jan 2022 16:58:50 +0100 > On 1/12/2022 8:00 AM, Richard Biener wrote: > > On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov > > wrote: > >> > >> On 2022-01-12 03:47, Richard Biener wrote: > >>> On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Jeff Law via Gcc-patches
On 1/12/2022 8:00 AM, Richard Biener wrote: On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov wrote: On 2022-01-12 03:47, Richard Biener wrote: On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches wrote: On 2022-01-11 12:42, Richard Sandiford wrote: The new IRA heuristics wou

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 4:00 PM Richard Biener wrote: > > On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov wrote: > > > > > > On 2022-01-12 03:47, Richard Biener wrote: > > > On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches > > > wrote: > > >> > > >> On 2022-01-11 12:42, Richard

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov wrote: > > > On 2022-01-12 03:47, Richard Biener wrote: > > On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches > > wrote: > >> > >> On 2022-01-11 12:42, Richard Sandiford wrote: > >>> The new IRA heuristics would need more work on old

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Vladimir Makarov via Gcc-patches
On 2022-01-12 03:47, Richard Biener wrote: On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches wrote: On 2022-01-11 12:42, Richard Sandiford wrote: The new IRA heuristics would need more work on old-reload targets, since flattening needs to be able to undo the cost propagation.

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Richard Biener via Gcc-patches
On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches wrote: > > > On 2022-01-11 12:42, Richard Sandiford wrote: > > The new IRA heuristics would need more work on old-reload targets, > > since flattening needs to be able to undo the cost propagation. > > It's doable, but hardly seems w

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-11 Thread Vladimir Makarov via Gcc-patches
On 2022-01-11 12:42, Richard Sandiford wrote: The new IRA heuristics would need more work on old-reload targets, since flattening needs to be able to undo the cost propagation. It's doable, but hardly seems worth it. Agree. It is not worth to spend your time for work for reload. This patch th

[PATCH] ira: Fix old-reload targets [PR103974]

2022-01-11 Thread Richard Sandiford via Gcc-patches
The new IRA heuristics would need more work on old-reload targets, since flattening needs to be able to undo the cost propagation. It's doable, but hardly seems worth it. This patch therefore makes all the new calls to ira_subloop_allocnos_can_differ_p return false if !ira_use_lra_p. The color_pas