Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-07-18 Thread Josef Melcr
Hello, On 7/11/25 6:47 PM, Martin Jambor wrote: Hello, and sorry for a rather late reaction. First and foremost, thanks for the patch, I think it is great to have this finally implemented and although I would like to see a couple things changed, I think the patch is quite close to what could b

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-07-11 Thread Martin Jambor
Hello, and sorry for a rather late reaction. First and foremost, thanks for the patch, I think it is great to have this finally implemented and although I would like to see a couple things changed, I think the patch is quite close to what could be committed to gcc master. After my first pass thr

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-06-16 Thread Jakub Jelinek
On Mon, Jun 16, 2025 at 08:14:53PM +0200, Josef Melcr wrote: > Certainly :) I am sorry about my lack of activity in the last two months, > I've been really busy, first with the thesis and now with studying for the > state finals.  I will hopefully wrap up these academic duties this Thursday > and I

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-06-16 Thread Josef Melcr
On 6/16/25 18:25, Jan Hubicka wrote: On Mon, Jun 16, 2025 at 05:49:19PM +0200, Jan Hubicka wrote: On Wed, Apr 30, 2025 at 08:56:57AM +0200, Jakub Jelinek wrote: On Mon, Apr 28, 2025 at 07:27:31PM +0200, Josef Melcr wrote: As for the attribute, I am honestly not too sure about what to do, as c

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-06-16 Thread Jan Hubicka
> On Mon, Jun 16, 2025 at 05:49:19PM +0200, Jan Hubicka wrote: > > > On Wed, Apr 30, 2025 at 08:56:57AM +0200, Jakub Jelinek wrote: > > > > On Mon, Apr 28, 2025 at 07:27:31PM +0200, Josef Melcr wrote: > > > > > As for the attribute, I am honestly not too sure about what to do, as > > > > > clang >

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-06-16 Thread Jakub Jelinek
On Mon, Jun 16, 2025 at 05:49:19PM +0200, Jan Hubicka wrote: > > On Wed, Apr 30, 2025 at 08:56:57AM +0200, Jakub Jelinek wrote: > > > On Mon, Apr 28, 2025 at 07:27:31PM +0200, Josef Melcr wrote: > > > > As for the attribute, I am honestly not too sure about what to do, as > > > > clang > > > > is

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-06-16 Thread Jan Hubicka
> On Wed, Apr 30, 2025 at 08:56:57AM +0200, Jakub Jelinek wrote: > > On Mon, Apr 28, 2025 at 07:27:31PM +0200, Josef Melcr wrote: > > > As for the attribute, I am honestly not too sure about what to do, as > > > clang > > > is > > > not consistent in with its own indexing, be it with the unknown v

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-06-16 Thread Jakub Jelinek
On Wed, Apr 30, 2025 at 08:56:57AM +0200, Jakub Jelinek wrote: > On Mon, Apr 28, 2025 at 07:27:31PM +0200, Josef Melcr wrote: > > As for the attribute, I am honestly not too sure about what to do, as clang > > is > > not consistent in with its own indexing, be it with the unknown values, or > > wit

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-29 Thread Jakub Jelinek
On Mon, Apr 28, 2025 at 07:27:31PM +0200, Josef Melcr wrote: > As for the attribute, I am honestly not too sure about what to do, as clang > is > not consistent in with its own indexing, be it with the unknown values, or > with > 'this'. I've tried to remain consistent with GCC's indexing style. I

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-28 Thread Josef Melcr
Dne 28. 04. 25 v 10:58 Jakub Jelinek napsal(a): On Sun, Apr 27, 2025 at 11:56:21AM +0200, Josef Melcr wrote: * builtin-attrs.def (0): New int list. This is just weird. Write * builtin-attrs.def: Add DEF_LIST_INT_INT (0,2). ? +DEF_CALLBACK_ATTRIBUTE(GOMP, 1, 0) +DEF_CALLBACK_

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-28 Thread Jakub Jelinek
On Sun, Apr 27, 2025 at 11:56:21AM +0200, Josef Melcr wrote: > * builtin-attrs.def (0): New int list. This is just weird. Write * builtin-attrs.def: Add DEF_LIST_INT_INT (0,2). ? > +DEF_CALLBACK_ATTRIBUTE(GOMP, 1, 0) > +DEF_CALLBACK_ATTRIBUTE(GOMP, 1, 2) > +DEF_CALLBACK_ATTRIBUTE(O

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-27 Thread Josef Melcr
Lambdas have crossed my mind, but I have not yet had the time to look thoroughly into their implementation and the issues they face. I do plan to look into them once I am done with some incremental improvements for the attribute and callback edges, as lambdas seem like a good candidate for this

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-27 Thread Andrew Pinski
On Sun, Apr 27, 2025 at 2:58 AM Josef Melcr wrote: > > This patch enables constant propagation to outlined OpenMP kernels and > improves support for optimizing callback functions in general. It > implements the attribute 'callback' as found in clang, though argument > numbering is a bit different,

[PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-27 Thread Josef Melcr
This patch enables constant propagation to outlined OpenMP kernels and improves support for optimizing callback functions in general. It implements the attribute 'callback' as found in clang, though argument numbering is a bit different, as described below. The title says OpenMP, but it can be used