Re: [PATCH] i386: Fix up cond_{and,ior,xor,mul}* [PR104779]

2022-03-07 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 07, 2022 at 10:15:48AM +0800, Hongtao Liu wrote: > > Note, the predicates on cond_fma* and other FMA variants look all wrong to > > me, usually the fma instructions require nonimmediate_operand operands, > > but the cond_* patterns use vector_operand. Besides what this patch >

Re: [PATCH] i386: Fix up cond_{and,ior,xor,mul}* [PR104779]

2022-03-06 Thread Hongtao Liu via Gcc-patches
On Sat, Mar 5, 2022 at 4:05 PM Jakub Jelinek wrote: > > Hi! > > The following testcase ICEs, because the cond_andv* expander > has vector_operand predicates in both of the commutative inputs > and calls gen_andv*_mask which calls ix86_binary_operator_ok > in its condition, but nothing calls ix86_f

[PATCH] i386: Fix up cond_{and,ior,xor,mul}* [PR104779]

2022-03-05 Thread Jakub Jelinek via Gcc-patches
Hi! The following testcase ICEs, because the cond_andv* expander has vector_operand predicates in both of the commutative inputs and calls gen_andv*_mask which calls ix86_binary_operator_ok in its condition, but nothing calls ix86_fixup_binary_operands_no_copy during the expansion, which means con