Re: [PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-26 Thread Segher Boessenkool
On Fri, Jun 26, 2015 at 09:42:06AM +0200, Uros Bizjak wrote: > Hello! > > > > > [ I see i386 also does PUT_CODE in a few more splitters, hrm. ] > > > > > > I think the splitters need to be fixed but I also think that > > > shallow_copy_rtx should > > > be enough, no? combine will not actually end

Re: [PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-26 Thread Uros Bizjak
Hello! > > > [ I see i386 also does PUT_CODE in a few more splitters, hrm. ] > > > > I think the splitters need to be fixed but I also think that > > shallow_copy_rtx should > > be enough, no? combine will not actually end up generating more references > > to the original RTX so we won't end up w

Re: [PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-25 Thread Segher Boessenkool
On Thu, Jun 25, 2015 at 11:59:28AM +0200, Richard Biener wrote: > On Thu, Jun 25, 2015 at 7:11 AM, Segher Boessenkool > wrote: > > On Wed, Jun 24, 2015 at 09:40:28PM -0600, Jeff Law wrote: > >> On 06/24/2015 05:29 PM, Segher Boessenkool wrote: > >> >A few define_split's in the i386 backend modify

Re: [PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-25 Thread Richard Biener
On Thu, Jun 25, 2015 at 7:11 AM, Segher Boessenkool wrote: > On Wed, Jun 24, 2015 at 09:40:28PM -0600, Jeff Law wrote: >> On 06/24/2015 05:29 PM, Segher Boessenkool wrote: >> >A few define_split's in the i386 backend modify RTL in place. This does >> >not work. This patch fixes all cases that do

Re: [PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-24 Thread Segher Boessenkool
On Wed, Jun 24, 2015 at 09:40:28PM -0600, Jeff Law wrote: > On 06/24/2015 05:29 PM, Segher Boessenkool wrote: > >A few define_split's in the i386 backend modify RTL in place. This does > >not work. This patch fixes all cases that do PUT_MODE on existing RTL. > > * config/i386/i386.md (variou

Re: [PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-24 Thread Jeff Law
On 06/24/2015 09:40 PM, Jeff Law wrote: On 06/24/2015 05:29 PM, Segher Boessenkool wrote: A few define_split's in the i386 backend modify RTL in place. This does not work. This patch fixes all cases that do PUT_MODE on existing RTL. Bootstrapped and tested; no regressions. Is this okay for t

Re: [PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-24 Thread Jeff Law
On 06/24/2015 05:29 PM, Segher Boessenkool wrote: A few define_split's in the i386 backend modify RTL in place. This does not work. This patch fixes all cases that do PUT_MODE on existing RTL. Bootstrapped and tested; no regressions. Is this okay for trunk? Hrm, this wants the testcase in th

[PATCH] i386: Do not modify existing RTL (PR66412)

2015-06-24 Thread Segher Boessenkool
A few define_split's in the i386 backend modify RTL in place. This does not work. This patch fixes all cases that do PUT_MODE on existing RTL. Bootstrapped and tested; no regressions. Is this okay for trunk? Hrm, this wants the testcase in that PR added I suppose. Will send it separately. S