Re: [PATCH] i386: Correct target attribute for crc32 intrinsics

2022-04-15 Thread Uros Bizjak via Gcc-patches
On Fri, Apr 15, 2022 at 10:34 AM Hongyu Wang wrote: > > > This test should not be changed, it correctly reports ISA mismatch. It > > even passes -mno-crc32. > > The error message changes from "needs isa option -mcrc32" to "target > specific option mismatch" with the #pragma change. > I see many of

Re: [PATCH] i386: Correct target attribute for crc32 intrinsics

2022-04-15 Thread Hongyu Wang via Gcc-patches
> This test should not be changed, it correctly reports ISA mismatch. It > even passes -mno-crc32. The error message changes from "needs isa option -mcrc32" to "target specific option mismatch" with the #pragma change. I see many of our intrinsic would throw such error, it has been a long term iss

Re: [PATCH] i386: Correct target attribute for crc32 intrinsics

2022-04-15 Thread Uros Bizjak via Gcc-patches
On Fri, Apr 15, 2022 at 6:30 AM Hongyu Wang wrote: > > Hi, > > Complile _mm_crc32_u8/16/32/64 intrinsics with -mcrc32 > would meet target specific option mismatch. Correct target pragma > to fix. > > Bootstrapped/regtest on x86_64-pc-linux-gnu{-m32,}. > > Ok for master and backport to GCC 11? > >

[PATCH] i386: Correct target attribute for crc32 intrinsics

2022-04-14 Thread Hongyu Wang via Gcc-patches
Hi, Complile _mm_crc32_u8/16/32/64 intrinsics with -mcrc32 would meet target specific option mismatch. Correct target pragma to fix. Bootstrapped/regtest on x86_64-pc-linux-gnu{-m32,}. Ok for master and backport to GCC 11? gcc/ChangeLog: * config/i386/smmintrin.h: Correct target pragma