Re: [PATCH] ginclude: stdalign.h should define __xxx_is_defined macros for C++

2024-10-23 Thread Jason Merrill
On 10/23/24 2:41 PM, Jonathan Wakely wrote: On Wed, 23 Oct 2024 at 16:02, Jason Merrill wrote: On 10/23/24 10:39 AM, Jonathan Wakely wrote: The __alignas_is_defined macro has been required by C++ since C++11, and C++ Library DR 4036 clarified that __alignof_is_defined should be defined too.

Re: [PATCH] ginclude: stdalign.h should define __xxx_is_defined macros for C++

2024-10-23 Thread Jonathan Wakely
On Wed, 23 Oct 2024 at 19:44, Jonathan Wakely wrote: > > On Wed, 23 Oct 2024 at 19:41, Jonathan Wakely wrote: > > > > On Wed, 23 Oct 2024 at 16:02, Jason Merrill wrote: > > > > > > Should there also/instead be a test with ? > > > > We don't usually (or ever?) bother to test the .h versions of he

Re: [PATCH] ginclude: stdalign.h should define __xxx_is_defined macros for C++

2024-10-23 Thread Jonathan Wakely
On Wed, 23 Oct 2024 at 19:41, Jonathan Wakely wrote: > > On Wed, 23 Oct 2024 at 16:02, Jason Merrill wrote: > > > > Should there also/instead be a test with ? > > We don't usually (or ever?) bother to test the .h versions of headers. > For these ones that are deprecated it probably makes sense to

Re: [PATCH] ginclude: stdalign.h should define __xxx_is_defined macros for C++

2024-10-23 Thread Jonathan Wakely
On Wed, 23 Oct 2024 at 16:02, Jason Merrill wrote: > > On 10/23/24 10:39 AM, Jonathan Wakely wrote: > > The __alignas_is_defined macro has been required by C++ since C++11, and > > C++ Library DR 4036 clarified that __alignof_is_defined should be > > defined too. > > > > The macros alignas and ali

Re: [PATCH] ginclude: stdalign.h should define __xxx_is_defined macros for C++

2024-10-23 Thread Jason Merrill
On 10/23/24 10:39 AM, Jonathan Wakely wrote: The __alignas_is_defined macro has been required by C++ since C++11, and C++ Library DR 4036 clarified that __alignof_is_defined should be defined too. The macros alignas and alignof should not be defined, as they're keywords in C++. Technically it's

[PATCH] ginclude: stdalign.h should define __xxx_is_defined macros for C++

2024-10-23 Thread Jonathan Wakely
The __alignas_is_defined macro has been required by C++ since C++11, and C++ Library DR 4036 clarified that __alignof_is_defined should be defined too. The macros alignas and alignof should not be defined, as they're keywords in C++. Technically it's implementation-defined whether __STDC_VERSION_