Re: [PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-24 Thread Jeff Law via Gcc-patches
On Mon, 2020-08-24 at 12:51 +0200, Richard Biener wrote: > On Wed, 12 Aug 2020, Jakub Jelinek wrote: > > > On Wed, Aug 12, 2020 at 04:30:35PM +0200, Richard Biener wrote: > > > Not a final review but if we care for this kind of normalization at all > > > the we should do so consistently, thus for

Re: [PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-24 Thread Richard Biener
On Wed, 12 Aug 2020, Jakub Jelinek wrote: > On Wed, Aug 12, 2020 at 04:30:35PM +0200, Richard Biener wrote: > > Not a final review but if we care for this kind of normalization at all > > the we should do so consistently, thus for both encode and interpret and > > for all modes. For FP we could a

Re: [PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 12, 2020 at 04:30:35PM +0200, Richard Biener wrote: > Not a final review but if we care for this kind of normalization at all > the we should do so consistently, thus for both encode and interpret and > for all modes. For FP we could also check if we'd consider the values > equal rathe

Re: [PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-12 Thread Richard Biener
On August 12, 2020 10:45:12 AM GMT+02:00, Jakub Jelinek wrote: >Hi! > >My patch to introduce native_encode_initializer to fold_ctor_reference >apparently broke gnulib/m4 on powerpc64. >There it uses a const union with two doubles and corresponding IBM >double >double long double which actually is

[PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-12 Thread Jakub Jelinek via Gcc-patches
Hi! My patch to introduce native_encode_initializer to fold_ctor_reference apparently broke gnulib/m4 on powerpc64. There it uses a const union with two doubles and corresponding IBM double double long double which actually is the largest normalizable long double value (1 ulp higher than __LDBL_MA