Re: [PATCH] gcc::context creation

2017-06-06 Thread Richard Biener
On Mon, 5 Jun 2017, Nathan Sidwell wrote: > On 06/05/2017 08:50 AM, Jakub Jelinek wrote: > > > It was the intent that there is no unnecessary gap, the difference > > between those two should be simply the maximum any FE registers. > > So, on your branch you'd bump it to 4 and on trunk when mergin

Re: [PATCH] gcc::context creation

2017-06-05 Thread Nathan Sidwell
On 06/05/2017 08:50 AM, Jakub Jelinek wrote: It was the intent that there is no unnecessary gap, the difference between those two should be simply the maximum any FE registers. So, on your branch you'd bump it to 4 and on trunk when merging your branch. I can live with that. nathan -- Nathan

Re: [PATCH] gcc::context creation

2017-06-05 Thread Jakub Jelinek
On Mon, Jun 05, 2017 at 08:46:21AM -0400, Nathan Sidwell wrote: > On 06/05/2017 07:47 AM, Jakub Jelinek wrote: > > > Whether there is a blank between function and its function comment > > is something we aren't consistent in, but it seems that in dumpfile.c > > there is a blank line, so I'm adjust

Re: [PATCH] gcc::context creation

2017-06-05 Thread Nathan Sidwell
On 06/05/2017 07:47 AM, Jakub Jelinek wrote: Whether there is a blank between function and its function comment is something we aren't consistent in, but it seems that in dumpfile.c there is a blank line, so I'm adjusting. Ok (I only know the blank line rule because someone nitted one of my p

Re: [PATCH] gcc::context creation

2017-06-05 Thread Jakub Jelinek
On Mon, Jun 05, 2017 at 06:57:47AM -0400, Nathan Sidwell wrote: > On 06/05/2017 05:46 AM, Jakub Jelinek wrote: > > > Here is a patch to implement that. I chose to keep the 3 dumps predefined > > dumps and just tweak their registered number, otherwise the changes would be > > bigger. > > Yeah, th

Re: [PATCH] gcc::context creation

2017-06-05 Thread Nathan Sidwell
On 06/05/2017 05:46 AM, Jakub Jelinek wrote: Here is a patch to implement that. I chose to keep the 3 dumps predefined dumps and just tweak their registered number, otherwise the changes would be bigger. Yeah, that can wait for another day. The patch additionally renames TDI_generic to TDI

Re: [PATCH] gcc::context creation

2017-06-05 Thread Jakub Jelinek
On Wed, May 24, 2017 at 08:00:30AM -0400, Nathan Sidwell wrote: > On 05/24/2017 07:57 AM, Jakub Jelinek wrote: > > > The numbering is not to differentiate between dumps of the same name, that > > is done through numbered suffixes of the dump names, but to make the order > > of passes visible to th

Re: [PATCH] gcc::context creation

2017-05-24 Thread Nathan Sidwell
On 05/24/2017 07:57 AM, Jakub Jelinek wrote: The numbering is not to differentiate between dumps of the same name, that is done through numbered suffixes of the dump names, but to make the order of passes visible to the user and for sorted file listing to be provided in that order. So, rather t

Re: [PATCH] gcc::context creation

2017-05-24 Thread Jakub Jelinek
On Wed, May 24, 2017 at 07:44:49AM -0400, Nathan Sidwell wrote: > On 05/24/2017 06:57 AM, Jakub Jelinek wrote: > > > So, first question, where should we order the -fdump-lang-* dumps, shall > > they go before .original/.gimple/.nested, or in between .original and > > .gimple/.nested, or after thos

Re: [PATCH] gcc::context creation

2017-05-24 Thread Nathan Sidwell
On 05/24/2017 06:57 AM, Jakub Jelinek wrote: So, first question, where should we order the -fdump-lang-* dumps, shall they go before .original/.gimple/.nested, or in between .original and .gimple/.nested, or after those 3 (the last option looks just wrong to me)? I think the lang dumps should

Re: [PATCH] gcc::context creation

2017-05-24 Thread Jakub Jelinek
On Wed, May 24, 2017 at 12:57:28PM +0200, Jakub Jelinek wrote: > So, first question, where should we order the -fdump-lang-* dumps, shall > they go before .original/.gimple/.nested, or in between .original and > .gimple/.nested, or after those 3 (the last option looks just wrong to me)? > Shall the

Re: [PATCH] gcc::context creation

2017-05-24 Thread Jakub Jelinek
On Thu, May 18, 2017 at 11:08:51AM -0400, Nathan Sidwell wrote: > On 05/16/2017 11:26 AM, Nathan Sidwell wrote: > > This patch breaks apart the creation of the pass manager from > > gcc::context's ctor. This will allow us to register additional dumps > ... https://gcc.gnu.org/ml/gcc-patches/2017-0

Re: [PATCH] gcc::context creation

2017-05-19 Thread Richard Biener
On Thu, May 18, 2017 at 5:08 PM, Nathan Sidwell wrote: > On 05/16/2017 11:26 AM, Nathan Sidwell wrote: >> >> This patch breaks apart the creation of the pass manager from >> gcc::context's ctor. This will allow us to register additional dumps > > ... https://gcc.gnu.org/ml/gcc-patches/2017-05/msg

Re: [PATCH] gcc::context creation

2017-05-19 Thread Richard Biener
On Tue, May 16, 2017 at 5:26 PM, Nathan Sidwell wrote: > This patch breaks apart the creation of the pass manager from gcc::context's > ctor. This will allow us to register additional dumps between the dumpfile > manager creation and the pass manager. As I described in > https://gcc.gnu.org/ml/g

Re: [PATCH] gcc::context creation

2017-05-18 Thread Nathan Sidwell
On 05/16/2017 11:26 AM, Nathan Sidwell wrote: This patch breaks apart the creation of the pass manager from gcc::context's ctor. This will allow us to register additional dumps ... https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01295.html This patch builds upon the context creation patch (this

[PATCH] gcc::context creation

2017-05-16 Thread Nathan Sidwell
This patch breaks apart the creation of the pass manager from gcc::context's ctor. This will allow us to register additional dumps between the dumpfile manager creation and the pass manager. As I described in https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01164.html when I tried to do this for