Re: [PATCH] fixincludes: vxworks: remove unnecessary parentheses in ioctl wrapper macro

2018-09-03 Thread Olivier Hainque
> On 3 Sep 2018, at 17:25, Bruce Korb wrote: > > On Mon, Sep 3, 2018 at 2:46 AM Olivier Hainque wrote: >>> -"#define ioctl(fd, func, arg) (ioctl)(fd, func, (int)(arg))\n"; >>> +"#define ioctl(fd, func, arg) ioctl(fd, func, (int)(arg))\n"; >> >> ok by me, thanks. > > Shouldn'

Re: [PATCH] fixincludes: vxworks: remove unnecessary parentheses in ioctl wrapper macro

2018-09-03 Thread Bruce Korb
On Mon, Sep 3, 2018 at 2:46 AM Olivier Hainque wrote: > > -"#define ioctl(fd, func, arg) (ioctl)(fd, func, (int)(arg))\n"; > > +"#define ioctl(fd, func, arg) ioctl(fd, func, (int)(arg))\n"; > > ok by me, thanks. Shouldn't this qualify as "trivial"? :)

Re: [PATCH] fixincludes: vxworks: remove unnecessary parentheses in ioctl wrapper macro

2018-09-03 Thread Olivier Hainque
Hi Rasmus, > On 29 Jun 2018, at 11:47, Rasmus Villemoes wrote: > -"#define ioctl(fd, func, arg) (ioctl)(fd, func, (int)(arg))\n"; > +"#define ioctl(fd, func, arg) ioctl(fd, func, (int)(arg))\n"; ok by me, thanks.

[PATCH] fixincludes: vxworks: remove unnecessary parentheses in ioctl wrapper macro

2018-06-29 Thread Rasmus Villemoes
The rationale for the fixinclude ioctl macro wrapper is, as far as I can tell (https://gcc.gnu.org/ml/gcc-patches/2012-09/msg01619.html) Fix 2: Add hack for ioctl() on VxWorks. ioctl() is supposed to be variadic, but VxWorks only has a three argument version with the third argument of type