Re: [PATCH] fix diagnostic quoting/spelling in rs6000

2019-05-21 Thread Segher Boessenkool
On Mon, May 20, 2019 at 11:31:17PM +, Joseph Myers wrote: > Where you refer to 'homogeneous % aggregates', are such aggregates > in the rs6000 case (or in the case where the ABI changed) really > restricted to the type float, or do they apply more generally to some > other floating-point typ

Re: [PATCH] fix diagnostic quoting/spelling in rs6000

2019-05-20 Thread Joseph Myers
Where you refer to 'homogeneous % aggregates', are such aggregates in the rs6000 case (or in the case where the ABI changed) really restricted to the type float, or do they apply more generally to some other floating-point types so that expanding "float" to a longer description would be the app

Re: [PATCH] fix diagnostic quoting/spelling in rs6000

2019-05-20 Thread Martin Liška
occurrences of the range notation at different places. > > > Okay for trunk, with the changelog nits, and Jakub's comment addressed. > > Thanks, Thanks for review. Martin > > > Segher > >From d3afdfe096a9955fccf851178cb9eadb8cddd93b Mon Sep 17 00:00:

Re: [PATCH] fix diagnostic quoting/spelling in rs6000

2019-05-20 Thread Segher Boessenkool
Hi! On Mon, May 20, 2019 at 11:48:45AM +0200, Martin Liška wrote: > * config/rs6000/driver-rs6000.c (elf_platform): Do not use > an extra newline. > * config/rs6000/rs6000-c.c (SYNTAX_ERROR): Wrap pragma in %<%>. Please say this is in rs6000_pragma_longcall. You might want to m

Re: [PATCH] fix diagnostic quoting/spelling in rs6000

2019-05-20 Thread Martin Liška
r %<-mcpu=native%>: > %s", cpu); > fatal_error (input_location, "please use an explicit cpu name; valid cpu > names are: %s", s); > or reword somehow. > > Jakub > You are right. I'm fixing that in updated patch. Thanks, Martin >From e8

Re: [PATCH] fix diagnostic quoting/spelling in rs6000

2019-05-20 Thread Jakub Jelinek
On Mon, May 20, 2019 at 11:48:45AM +0200, Martin Liška wrote: > --- a/gcc/config/rs6000/driver-rs6000.c > +++ b/gcc/config/rs6000/driver-rs6000.c > @@ -266,7 +266,7 @@ elf_platform (void) > fatal_error ( > input_location, > "Unsupported cpu name returned from kernel for

[PATCH] fix diagnostic quoting/spelling in rs6000

2019-05-20 Thread Martin Liška
Hi. The patch is about fallout of -Wformat-diag for ppc64le target where I added quoting of various warnings and errors. Patch can bootstrap on ppc64le-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-05-16 Martin Liska * config/rs6