Re: [PATCH] fix PR sanitizer/55617 via qsort - dtors part

2013-02-04 Thread Jakub Jelinek
On Mon, Feb 04, 2013 at 04:58:02PM -0500, Jack Howarth wrote: > --- gcc/config/darwin.c (revision 195735) > +++ gcc/config/darwin.c (working copy) > @@ -89,7 +89,14 @@ typedef struct GTY(()) ctor_record { >int position; /* original position */ > } ctor_record; > > +t

Re: [PATCH] fix PR sanitizer/55617 via qsort

2013-02-04 Thread Jakub Jelinek
On Mon, Feb 04, 2013 at 03:24:41PM -0500, Jack Howarth wrote: > --- /dev/null 2013-02-02 10:53:51.0 -0500 > +++ gcc/testsuite/g++.dg/asan/pr55617.C 2013-02-02 10:22:17.0 > -0500 > @@ -0,0 +1,8 @@ > +// { dg-do run { target { i?86-*-darwin* x86_64-*-darwin* } } } There is not

[PATCH] fix PR sanitizer/55617 via qsort - dtors part

2013-02-04 Thread Jack Howarth
Mike, Attached is the requested qsort on destructors as well. After gcc branches for 4.8, I would imagine the first baby step towards full constructor/destructor priority support would be to remove... /* The Apple assembler and linker do not support constructor priorities. */ #undef SUPPORTS_I

Re: [PATCH] fix PR sanitizer/55617 via qsort

2013-02-04 Thread Mike Stump
On Feb 4, 2013, at 12:24 PM, Jack Howarth wrote: > Complete patch with testcase attached. Thanks. Committed revision 195737.

Re: [PATCH] fix PR sanitizer/55617 via qsort

2013-02-04 Thread Jack Howarth
On Mon, Feb 04, 2013 at 12:12:36PM -0800, Mike Stump wrote: > On Feb 4, 2013, at 11:23 AM, Mike Stump wrote: > > On Feb 4, 2013, at 9:22 AM, Jack Howarth wrote: > >> Currently darwin is unable to utilize libasan with constructors due to > >> the lack of > >> constructor priority support on that

Re: [PATCH] fix PR sanitizer/55617 via qsort

2013-02-04 Thread Mike Stump
On Feb 4, 2013, at 11:23 AM, Mike Stump wrote: > On Feb 4, 2013, at 9:22 AM, Jack Howarth wrote: >> Currently darwin is unable to utilize libasan with constructors due to the >> lack of >> constructor priority support on that target. > >> Okay for gcc trunk? > > Since asan doesn't need cross

Re: [PATCH] fix PR sanitizer/55617 via qsort

2013-02-04 Thread Mike Stump
On Feb 4, 2013, at 11:23 AM, Mike Stump wrote: > On Feb 4, 2013, at 9:22 AM, Jack Howarth wrote: >> Currently darwin is unable to utilize libasan with constructors due to the >> lack of >> constructor priority support on that target. > >> Okay for gcc trunk? > > Since asan doesn't need cross

Re: [PATCH] fix PR sanitizer/55617 via qsort

2013-02-04 Thread Mike Stump
On Feb 4, 2013, at 9:22 AM, Jack Howarth wrote: > Currently darwin is unable to utilize libasan with constructors due to the > lack of > constructor priority support on that target. > Okay for gcc trunk? Since asan doesn't need cross translation unit priorities, the patch is sufficient to fi

[PATCH] fix PR sanitizer/55617 via qsort

2013-02-04 Thread Jack Howarth
Currently darwin is unable to utilize libasan with constructors due to the lack of constructor priority support on that target. The asan_finish_file routine inserts an essential __asan_init into the array of constructors (via the __mod_init_func section). However the insertion occurs at the e