Re: [PATCH] fix -Wsign-compare error in objc-act.c (PR objc/50743)

2011-10-18 Thread Nicola Pero
> The FSF has had my papers since Feb '11, but are stalling trying to decide > whether to accept my employer's slightly non-standard disclaimer or not. Ah. That seems a long time even for this kind of things. Anyhow, this particular patch consisted of exactly 4 casts, so it seems to fall in the

Re: [PATCH] fix -Wsign-compare error in objc-act.c (PR objc/50743)

2011-10-17 Thread Mikael Pettersson
Nicola Pero writes: > > (I don't have svn write access so I'll need someone else to commit it if > > it's approved.) > > I can apply it for you. But ... do you have a copyright assignment in place > for contributions to GCC ? The patch looks small and trivial enough that > I think I can ap

Re: [PATCH] fix -Wsign-compare error in objc-act.c (PR objc/50743)

2011-10-17 Thread Nicola Pero
> (I don't have svn write access so I'll need someone else to commit it if > it's approved.) I can apply it for you. But ... do you have a copyright assignment in place for contributions to GCC ? The patch looks small and trivial enough that I think I can apply it without a signed copyright assi

Re: [PATCH] fix -Wsign-compare error in objc-act.c (PR objc/50743)

2011-10-16 Thread Mike Stump
On Oct 16, 2011, at 4:28 AM, Mikael Pettersson wrote: > This fixes a bootstrap failure on trunk with objc enabled > Ok for trunk? Ok.

[PATCH] fix -Wsign-compare error in objc-act.c (PR objc/50743)

2011-10-16 Thread Mikael Pettersson
This fixes a bootstrap failure on trunk with objc enabled, caused by a recent change which introduced for-loops that compare a size_t index variable with a TREE_VEC_LENGTH limit. TREE_VEC_LENGTH returns a signed integer, resulting in a signed/unsigned comparison. The C++ front-end fails to catch