Re: [PATCH] detect references to statics in inline function signatures (PR 88718)

I posted the patch right on the cusp of stage 4, thinking it was still stage 3. I thought I could finish it quickly but after the last round of comments I decided to move on to stage 4 stuff. I've contemplating coming back to it at some point. That being said, the patch fixes the reported bug wi

Re: [PATCH] detect references to statics in inline function signatures (PR 88718)

I already reviewed two versions of this patch. As far as I know, no third version has been posted to address my comments on the second version . -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] detect references to statics in inline function signatures (PR 88718)

On Fri, May 31, 2019 at 9:48 PM Jeff Law wrote: > > On 1/11/19 1:10 PM, Martin Sebor wrote: > > The attached patch extends the detection of references to static > > variables in inline functions to the function signatures, including > > their return type. Since the declaration of a function need

Re: [PATCH] detect references to statics in inline function signatures (PR 88718)

On 1/11/19 1:10 PM, Martin Sebor wrote: > The attached patch extends the detection of references to static > variables in inline functions to the function signatures, including > their return type.  Since the declaration of a function need not be > yet available at the time the static is referenced

Re: [PATCH] detect references to statics in inline function signatures (PR 88718)

On Wed, 16 Jan 2019, Martin Sebor wrote: > + /* Iterate over tentative records (all those at the head of the list > + with a null FUNCTION) and either associate them with DECL when ADD > + is set or remove them from it otherwise. */ > + for (c_inline_static *csi = c_inline_statics, *las

Re: [PATCH] detect references to statics in inline function signatures (PR 88718)

On 1/11/19 2:27 PM, Joseph Myers wrote: On Fri, 11 Jan 2019, Martin Sebor wrote: gcc/testsuite/ChangeLog: PR c/88718 * gcc.dg/inline-40.c: New test. * gcc.dg/inline-41.c: New test. We already have tests inline-40.c and inline-41.c; these need to be renumbered accordin

Re: [PATCH] detect references to statics in inline function signatures (PR 88718)

On Fri, 11 Jan 2019, Martin Sebor wrote: > gcc/testsuite/ChangeLog: > > PR c/88718 > * gcc.dg/inline-40.c: New test. > * gcc.dg/inline-41.c: New test. We already have tests inline-40.c and inline-41.c; these need to be renumbered accordingly. > + if (add) > + { > +

[PATCH] detect references to statics in inline function signatures (PR 88718)

The attached patch extends the detection of references to static variables in inline functions to the function signatures, including their return type. Since the declaration of a function need not be yet available at the time the static is referenced (e.g., when it's referenced in the functions r