Re: [PATCH] cselib: Don't consider SP_DERIVED_VALUE_P values as useless [PR94468]

2020-04-04 Thread Richard Biener
On April 4, 2020 12:42:33 AM GMT+02:00, Jakub Jelinek wrote: >On Fri, Apr 03, 2020 at 07:42:10PM +0200, Jakub Jelinek via Gcc-patches >wrote: >> Or, to avoid the repetitive code, should I introduce >> static bool >> cselib_useless_value_p (cselib_val *v) >> { >> return (v->locs == 0 >>&&

Re: [PATCH] cselib: Don't consider SP_DERIVED_VALUE_P values as useless [PR94468]

2020-04-03 Thread Jakub Jelinek via Gcc-patches
On Fri, Apr 03, 2020 at 07:42:10PM +0200, Jakub Jelinek via Gcc-patches wrote: > Or, to avoid the repetitive code, should I introduce > static bool > cselib_useless_value_p (cselib_val *v) > { > return (v->locs == 0 > && !PRESERVED_VALUE_P (v->val_rtx) > && !SP_DERIVED_VALUE_P (v-

[PATCH] cselib: Don't consider SP_DERIVED_VALUE_P values as useless [PR94468]

2020-04-03 Thread Jakub Jelinek via Gcc-patches
Hi! The following testcase ICEs, because at one point we see the SP_DERIVED_VALUE_P VALUE as useless (not PRESERVED_VALUE_P and no locs) and so expect it to be discarded as useless. But, later on we are adding some new VALUE that is equivalent to it, and when adding the equivalency that that new