Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0)))

2015-05-13 Thread Segher Boessenkool
On Mon, May 11, 2015 at 06:13:40AM -0700, Segher Boessenkool wrote: > * combine.c (simplify_set): When generating a CC set, if the > source already is in the correct mode, do not wrap it in a > compare. Simplify the rest of that code. Committed now. Segher

Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0)))

2015-05-11 Thread Jeff Law
On 05/11/2015 03:11 PM, Segher Boessenkool wrote: On Mon, May 11, 2015 at 11:23:47AM -0600, Jeff Law wrote: * combine.c (simplify_set): When generating a CC set, if the source already is in the correct mode, do not wrap it in a compare. Simplify the rest of that code. S

Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0)))

2015-05-11 Thread Segher Boessenkool
On Mon, May 11, 2015 at 11:23:47AM -0600, Jeff Law wrote: > > * combine.c (simplify_set): When generating a CC set, if the > > source already is in the correct mode, do not wrap it in a > > compare. Simplify the rest of that code. > Seems reasonable. Might not hurt to do a little test

Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0)))

2015-05-11 Thread Jeff Law
On 05/11/2015 07:13 AM, Segher Boessenkool wrote: There already was code to just use the original reg:CC, but it was positioned incorrectly: if the original code (that this RTL is simplified from) did not already start with a COMPARE (or not in the right mode), it didn't trigger. But it is valid

[PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0)))

2015-05-11 Thread Segher Boessenkool
There already was code to just use the original reg:CC, but it was positioned incorrectly: if the original code (that this RTL is simplified from) did not already start with a COMPARE (or not in the right mode), it didn't trigger. But it is valid in that case as well. This then allows merging the