On Wed, Apr 02, 2025 at 04:24:30PM -0500, Robert Dubner wrote:
> Solutions have been put in place that don't involve modifying the source
> code of the copied files. I haven't made an opportunity to understand how
> they work, but I am choosing to drop the matter.
In order to unbreak Darwin, I'v
On Sat, Mar 29, 2025 at 04:03:07PM +, Iain Sandoe wrote:
>
>
> > On 29 Mar 2025, at 15:56, Jakub Jelinek wrote:
> >
> > On Sat, Mar 29, 2025 at 03:50:54PM +, Iain Sandoe wrote:
> >>> I'm not sure if sed -E is portable enough (sure, I know it is in POSIX,
> >>> but
> >>> that is not eno
Hi Jakub
Thanks for doing this...
> On 28 Mar 2025, at 14:39, Jakub Jelinek wrote:
>
> +cobol/charmaps.cc cobol/valconv.cc: cobol/%.cc: $(LIB_SOURCE)/%.cc
> + -l='ec\|common-defs\|io\|gcobolio\|libgcobol\|gfileio\|charmaps'; \
> + l=$$l'\|valconv\|exceptl'; \
> + sed -e '/^#include/
> -Original Message-
> From: Iain Sandoe
> Sent: Wednesday, April 2, 2025 15:34
> To: Robert Dubner
> Cc: Jakub Jelinek ; James K. Lowden
> ; Richard Biener ; GCC Patches
>
> Subject: Re: [PATCH] cobol: Fix up cobol/{charmaps,valconv}.cc rules
>
>
s K. Lowden ; Richard Biener
>> ; GCC Patches
>> Subject: RE: [PATCH] cobol: Fix up cobol/{charmaps,valconv}.cc rules
>>
>> Folks: Am I missing something stupid here?
>>
>> I just tried putting
>>
>> CXXFLAGS_SAVE=$(CXXFLAGS)
>> override CXX
akub Jelinek ; Iain Sandoe
> Cc: James K. Lowden ; Richard Biener
> ; GCC Patches
> Subject: RE: [PATCH] cobol: Fix up cobol/{charmaps,valconv}.cc rules
>
> Folks: Am I missing something stupid here?
>
> I just tried putting
>
> CXXFLAGS_SAVE=$(CXXFLAGS)
> override CXX
--Original Message-
> From: Jakub Jelinek
> Sent: Saturday, March 29, 2025 12:12
> To: Iain Sandoe
> Cc: Robert Dubner ; James K. Lowden
> ; Richard Biener ; GCC Patches
>
> Subject: Re: [PATCH] cobol: Fix up cobol/{charmaps,valconv}.cc rules
>
> On Sat, Mar 29
> On 29 Mar 2025, at 16:12, Jakub Jelinek wrote:
>
> On Sat, Mar 29, 2025 at 04:03:07PM +, Iain Sandoe wrote:
>>
>>
>>> On 29 Mar 2025, at 15:56, Jakub Jelinek wrote:
>>>
>>> On Sat, Mar 29, 2025 at 03:50:54PM +, Iain Sandoe wrote:
> I'm not sure if sed -E is portable enough (s
> On 29 Mar 2025, at 15:56, Jakub Jelinek wrote:
>
> On Sat, Mar 29, 2025 at 03:50:54PM +, Iain Sandoe wrote:
>>> I'm not sure if sed -E is portable enough (sure, I know it is in POSIX, but
>>> that is not enough).
>>> How about just
>>> sed -e '/^#include/s,"\([^"]*.h\)","../../libgco
On Sat, Mar 29, 2025 at 03:50:54PM +, Iain Sandoe wrote:
> > I'm not sure if sed -E is portable enough (sure, I know it is in POSIX, but
> > that is not enough).
> > How about just
> > sed -e '/^#include/s,"\([^"]*.h\)","../../libgcobol/\1",' $& > $@
>
> This, unfortunately, works too well
> On 29 Mar 2025, at 15:28, Jakub Jelinek wrote:
>
> On Sat, Mar 29, 2025 at 03:18:20PM +, Iain Sandoe wrote:
>> Hi Jakub
>>
>> Thanks for doing this...
>>
>>> On 28 Mar 2025, at 14:39, Jakub Jelinek wrote:
>>>
>>> +cobol/charmaps.cc cobol/valconv.cc: cobol/%.cc: $(LIB_SOURCE)/%.cc
>>>
On Sat, Mar 29, 2025 at 03:18:20PM +, Iain Sandoe wrote:
> Hi Jakub
>
> Thanks for doing this...
>
> > On 28 Mar 2025, at 14:39, Jakub Jelinek wrote:
> >
> > +cobol/charmaps.cc cobol/valconv.cc: cobol/%.cc: $(LIB_SOURCE)/%.cc
> > + -l='ec\|common-defs\|io\|gcobolio\|libgcobol\|gfileio\|ch
t.
I do have sympathy for the idea that the actual paths should be readable
in the source that the user deals with - it makes intentions clear.
Iain
>
>
>> -Original Message-
>> From: Jakub Jelinek
>> Sent: Friday, March 28, 2025 10:40
>> To: Robert Dubner ; Ja
eans, we should do so.
I just wasn't able figure out how to do it.
> -Original Message-
> From: Jakub Jelinek
> Sent: Friday, March 28, 2025 10:40
> To: Robert Dubner ; James K. Lowden
> ; Richard Biener
> Cc: gcc-patches@gcc.gnu.org
> Subject: [PATCH] cobol: Fix up cobol/{char
Thanks, I agree that the explicit include of library headers from
frontend should include the library folder explicitly.
On Fri, Mar 28, 2025 at 04:28:53PM +0100, Simon Sobisch wrote:
> +cobol/charmaps.cc cobol/valconv.cc: cobol/%.cc: $(LIB_SOURCE)/%.cc
> + -l='ec\|common-defs\|io\|gcobolio\|libgcobol\|gfileio\|charmaps'; \
> + l=$$l'\|valconv\|exceptl'; \
> + sed -e '/^#include/s,"\('$$l'\)\.h","../../li
+cobol/charmaps.cc cobol/valconv.cc: cobol/%.cc: $(LIB_SOURCE)/%.cc
+ -l='ec\|common-defs\|io\|gcobolio\|libgcobol\|gfileio\|charmaps'; \
+ l=$$l'\|valconv\|exceptl'; \
+ sed -e '/^#include/s,"\('$$l'\)\.h","../../libgcobol/\1.h",' $^ > $@
The proposed rule is much better than
On Fri, 28 Mar 2025, Jakub Jelinek wrote:
> Hi!
>
> sed -i is not portable, it is supported by GNU sed and perhaps some BSDs,
> but not elsewhere.
> Furthermore, I think it is far better to always use
> #include "../../libgcobol/something.h"
> paths rather than something depending on the build di
Hi!
sed -i is not portable, it is supported by GNU sed and perhaps some BSDs,
but not elsewhere.
Furthermore, I think it is far better to always use
#include "../../libgcobol/something.h"
paths rather than something depending on the build directory.
And because we require GNU make, we don't have t
19 matches
Mail list logo
