Re: [PATCH] cleanup in c-parser

2014-10-13 Thread Manuel López-Ibáñez
On 13 October 2014 20:52, Jeff Law wrote: > On 10/13/14 05:11, Anthony Brandon wrote: >> >> I updated the patch with a comment. Actually, Manuel handed me this >> patch just to help me get familiar with the process of submitting and >> testing. >> Generating this one with git diff looks different

Re: [PATCH] cleanup in c-parser

2014-10-13 Thread Jeff Law
On 10/13/14 05:11, Anthony Brandon wrote: I updated the patch with a comment. Actually, Manuel handed me this patch just to help me get familiar with the process of submitting and testing. Generating this one with git diff looks different so I'm not sure if that's a problem or not. This version

Re: [PATCH] cleanup in c-parser

2014-10-13 Thread Anthony Brandon
I updated the patch with a comment. Actually, Manuel handed me this patch just to help me get familiar with the process of submitting and testing. Generating this one with git diff looks different so I'm not sure if that's a problem or not. Thanks, Anthony On Sun, Oct 12, 2014 at 10:09 PM, wrot

Re: [PATCH] cleanup in c-parser

2014-10-12 Thread pinskia
> On Oct 12, 2014, at 12:37 PM, Anthony Brandon > wrote: > > Hi, > > I'm a new contributor and I don't yet have a copyright assignment or > commit access. Thanks for you contribution. Your new function is missing a comment before it saying what it does. Yes it might be obvious what the

[PATCH] cleanup in c-parser

2014-10-12 Thread Anthony Brandon
Hi, I'm a new contributor and I don't yet have a copyright assignment or commit access. This is a cleanup of code duplication in c-parser. I bootstrapped and tested on x86_64-linux. gcc/c/ChangeLog: 2014-10-12 Anthony Brandon * c-parser.c (c_parser_all_labels): New function to repl