Re: [PATCH] c-family: Fix ICE on __builtin_speculation_safe_value () [PR94755]

2020-04-27 Thread Nathan Sidwell
On 4/26/20 10:59 AM, Jakub Jelinek wrote: On Sun, Apr 26, 2020 at 09:58:16AM -0400, Nathan Sidwell wrote: first_param = (*params)[0]; - if (fncode == BUILT_IN_NONE - || !speculation_safe_value_resolve_params (loc, function, params)) + if (!speculation_safe_value_r

Re: [PATCH] c-family: Fix ICE on __builtin_speculation_safe_value () [PR94755]

2020-04-26 Thread Jakub Jelinek via Gcc-patches
On Sun, Apr 26, 2020 at 09:58:16AM -0400, Nathan Sidwell wrote: > > --- gcc/c-family/c-common.c.jj 2020-03-21 18:29:58.989160193 +0100 > > +++ gcc/c-family/c-common.c 2020-04-25 10:13:14.158722031 +0200 > > @@ -7402,9 +7402,11 @@ resolve_overloaded_builtin (location_t l > > enum built_in_f

Re: [PATCH] c-family: Fix ICE on __builtin_speculation_safe_value () [PR94755]

2020-04-26 Thread Nathan Sidwell
On 4/26/20 8:23 AM, Jakub Jelinek wrote: Hi! When this builtin has no parameters, speculation_safe_value_resolve_call returns BUILT_IN_NONE, but resolve_overloaded_builtin uselessly dereferences the first param just to return error_mark_node immediately. The following patch rearranges it so tha

[PATCH] c-family: Fix ICE on __builtin_speculation_safe_value () [PR94755]

2020-04-26 Thread Jakub Jelinek via Gcc-patches
Hi! When this builtin has no parameters, speculation_safe_value_resolve_call returns BUILT_IN_NONE, but resolve_overloaded_builtin uselessly dereferences the first param just to return error_mark_node immediately. The following patch rearranges it so that we only read the first parameter if fncod