Re: [PATCH] c++: mutable temps in rodata [PR116369]

2024-09-10 Thread Jason Merrill
On 8/29/24 4:15 PM, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? OK. -- >8 -- Here we wrongly mark the reference temporary for g TREE_READONLY, so it's put in .rodata and so we can't modify its subobject even when the subobject is marked mutable. Th

Re: [PATCH] c++: mutable temps in rodata [PR116369]

2024-09-09 Thread Marek Polacek
Ping. On Thu, Aug 29, 2024 at 04:15:41PM -0400, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? > > -- >8 -- > Here we wrongly mark the reference temporary for g TREE_READONLY, > so it's put in .rodata and so we can't modify its subobject even > when the

[PATCH] c++: mutable temps in rodata [PR116369]

2024-08-29 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14/13? -- >8 -- Here we wrongly mark the reference temporary for g TREE_READONLY, so it's put in .rodata and so we can't modify its subobject even when the subobject is marked mutable. This is so since r9-869. r14-1785 fixed a similar pr