Re: [PATCH] c++: more ahead-of-time -Wparentheses warnings

2023-10-26 Thread Jason Merrill
like so? Bootstrap / regtest in progress. -- >8 -- Subject: [PATCH] c++: more ahead-of-time -Wparentheses warnings Now that we don't have to worry about looking through NON_DEPENDENT_EXPR, we can easily extend the -Wparentheses warning in convert_for_assignment to consider (non-depe

Re: [PATCH] c++: more ahead-of-time -Wparentheses warnings

2023-10-26 Thread Patrick Palka
plicit > > > INDIRECT_REF in -Wparentheses warning logic, and generalize > > > to use is_assignment_op_expr_p. > > > > Do we want to factor out the whole warning logic rather than adjust it in > > both > > places? > > Sounds good, like so? Boot

Re: [PATCH] c++: more ahead-of-time -Wparentheses warnings

2023-10-26 Thread Patrick Palka
o we want to factor out the whole warning logic rather than adjust it in both > places? Sounds good, like so? Bootstrap / regtest in progress. -- >8 -- Subject: [PATCH] c++: more ahead-of-time -Wparentheses warnings Now that we don't have to worry about looking through NON_DEPENDENT_EX

Re: [PATCH] c++: more ahead-of-time -Wparentheses warnings

2023-10-26 Thread Jason Merrill
On 10/25/23 14:55, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Now that we don't have to worry about looking thruogh NON_DEPENDENT_EXPR, we can easily extend the -Wparentheses warning in convert_for_assignment to consider (non-de

[PATCH] c++: more ahead-of-time -Wparentheses warnings

2023-10-25 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Now that we don't have to worry about looking thruogh NON_DEPENDENT_EXPR, we can easily extend the -Wparentheses warning in convert_for_assignment to consider (non-dependent) templated assignment operator exp