Re: [PATCH] c++: Tweaks for value_dependent_expression_p.

2020-11-07 Thread Jozef Lawrynowicz
On Fri, Oct 30, 2020 at 02:36:00AM +, Marek Polacek via Gcc-patches wrote: > We may not call value_dependent_expression_p on expressions that are > not potential constant expressions, otherwise value_d could crash, > as I saw recently (in C++98). So beef up the checking in i_d_e_p. > > This r

Re: [PATCH] c++: Tweaks for value_dependent_expression_p.

2020-10-30 Thread Jason Merrill via Gcc-patches
On 10/29/20 10:36 PM, Marek Polacek wrote: We may not call value_dependent_expression_p on expressions that are not potential constant expressions, otherwise value_d could crash, as I saw recently (in C++98). So beef up the checking in i_d_e_p. This revealed a curious issue: when we have __PRET

[PATCH] c++: Tweaks for value_dependent_expression_p.

2020-10-29 Thread Marek Polacek via Gcc-patches
We may not call value_dependent_expression_p on expressions that are not potential constant expressions, otherwise value_d could crash, as I saw recently (in C++98). So beef up the checking in i_d_e_p. This revealed a curious issue: when we have __PRETTY_FUNCTION__ in a template function, we set