Re: [PATCH] c++: Properly fold .* [PR114525]

2025-04-14 Thread Simon Martin
Hi, On Tue Mar 25, 2025 at 8:33 PM CET, Simon Martin wrote: > Hi, > > On Tue Mar 25, 2025 at 6:52 PM CET, Jason Merrill wrote: >> On 3/25/25 1:50 PM, Marek Polacek wrote: >>> On Tue, Mar 25, 2025 at 05:18:23PM +, Simon Martin wrote: We've been miscompiling the following since r0-51314-gd6

[PATCH] c++: Properly fold .* [PR114525]

2025-04-05 Thread Simon Martin
We've been miscompiling the following since r0-51314-gd6b4ea8592e338 (I did not go compile something that old, and identified this change via git blame, so might be wrong) === cut here === struct Foo { int x; }; Foo& get (Foo &v) { return v; } void bar () { Foo v; v.x = 1; (true ? get (v) : ge

Re: [PATCH] c++: Properly fold .* [PR114525]

2025-03-26 Thread Jason Merrill
On 3/25/25 1:50 PM, Marek Polacek wrote: On Tue, Mar 25, 2025 at 05:18:23PM +, Simon Martin wrote: We've been miscompiling the following since r0-51314-gd6b4ea8592e338 (I did not go compile something that old, and identified this change via git blame, so might be wrong) === cut here === str

Re: [PATCH] c++: Properly fold .* [PR114525]

2025-03-25 Thread Simon Martin
Hi, On Tue Mar 25, 2025 at 6:52 PM CET, Jason Merrill wrote: > On 3/25/25 1:50 PM, Marek Polacek wrote: >> On Tue, Mar 25, 2025 at 05:18:23PM +, Simon Martin wrote: >>> We've been miscompiling the following since r0-51314-gd6b4ea8592e338 (I >>> did not go compile something that old, and identi

Re: [PATCH] c++: Properly fold .* [PR114525]

2025-03-25 Thread Marek Polacek
On Tue, Mar 25, 2025 at 05:18:23PM +, Simon Martin wrote: > We've been miscompiling the following since r0-51314-gd6b4ea8592e338 (I > did not go compile something that old, and identified this change via > git blame, so might be wrong) > > === cut here === > struct Foo { int x; }; > Foo& get (

Re: [PATCH] c++: Properly fold .* [PR114525]

2025-03-25 Thread Jason Merrill
On 3/25/25 1:18 PM, Simon Martin wrote: We've been miscompiling the following since r0-51314-gd6b4ea8592e338 (I did not go compile something that old, and identified this change via git blame, so might be wrong) === cut here === struct Foo { int x; }; Foo& get (Foo &v) { return v; } void bar ()